Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15047
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Thu, 17 Feb 2005 13:28:38 +0000
To: internals@lists.php.net
Message-ID: <20050217132838.GB28565@redhat.com>
Mail-Followup-To: internals@lists.php.net
References: <20050217112613.GA30445@redhat.com> <421482B3.20504@bitflux.ch> <42148BE2.5000406@ctindustries.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <42148BE2.5000406@ctindustries.net>
User-Agent: Mutt/1.4.1i
Subject: Re: [PHP-DEV] [PATCH] ext/xml/compat.c fix for #32001
From: jorton@redhat.com (Joe Orton)

On Thu, Feb 17, 2005 at 07:19:46AM -0500, Rob Richards wrote:
> It looks like there would be BC breaks unless libxml with the bug fix is 
> used as the encoding is detected properly and no infinite loop if an xml 
> declaration or BOM is used in the xml. So basically with the patch there 
> is no more autodetecting if used with any other libxml versions (though 
> no more possibilities of inifinte loops).

That's not quite right: detection based on an ASCII <?xml prolog with an
explicit encoding= still works fine with the patch applied (e.g. for
encoding=ISO-8859-1 documents).  It's *only* documents which have a BOM
which will then fail to parse.

So it is a bit of a tricky trade-off...