Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15045
Return-Path: <rrichards@ctindustries.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 72740 invoked by uid 1010); 17 Feb 2005 12:15:32 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 72717 invoked from network); 17 Feb 2005 12:15:32 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 17 Feb 2005 12:15:32 -0000
X-Host-Fingerprint: 216.117.147.250 unknown Linux 2.4/2.6
Received: from ([216.117.147.250:36880] helo=ctindustries.net)
	by pb1.pair.com (ecelerity 1.2 (r4437)) with SMTP
	id 31/09-21802-4EA84124 for <internals@lists.php.net>; Thu, 17 Feb 2005 07:15:32 -0500
Received: from [127.0.0.1] (dsta-aa203.pivot.net [66.186.171.203])
	(authenticated bits=0)
	by ctindustries.net (8.12.8/8.12.8) with ESMTP id j1HB9DaR009676;
	Thu, 17 Feb 2005 06:09:30 -0500
Message-ID: <42148BE2.5000406@ctindustries.net>
Date: Thu, 17 Feb 2005 07:19:46 -0500
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Christian Stocker <chregu@bitflux.ch>
CC: Joe Orton <jorton@redhat.com>, internals@lists.php.net
References: <20050217112613.GA30445@redhat.com> <421482B3.20504@bitflux.ch>
In-Reply-To: <421482B3.20504@bitflux.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV 0.82/707/Wed Feb 16 17:00:07 2005 on ctindustries.net
X-Virus-Status: Clean
Subject: Re: [PHP-DEV] [PATCH] ext/xml/compat.c fix for #32001
From: rrichards@ctindustries.net (Rob Richards)

It looks like there would be BC breaks unless libxml with the bug fix is 
used as the encoding is detected properly and no infinite loop if an xml 
declaration or BOM is used in the xml. So basically with the patch there 
is no more autodetecting if used with any other libxml versions (though 
no more possibilities of inifinte loops).

i.e.
$simple = "<?xml version='1.0'?><para><note>simple note</note></para>";
$simple = "\xEF\xBB\xBF<para><note>simple note</note></para>";

These both currently work without going into an infinite loop.

Rob

Christian Stocker wrote:

> Any BC breaks with that? Do I have to know now the encoding of the XML 
> document, before I can use the push parser? But reading your bugreport 
> at gnome.org, I assume it just defaults to UTF-8, right?
>