Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15009 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85209 invoked by uid 1010); 16 Feb 2005 06:10:44 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 85194 invoked from network); 16 Feb 2005 06:10:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Feb 2005 06:10:44 -0000 X-Host-Fingerprint: 192.38.9.232 gw2.emini.dk Linux 2.4/2.6 Received: from ([192.38.9.232:22012] helo=gw2.emini.dk) by pb1.pair.com (ecelerity 1.2 (r4437)) with SMTP id 72/5D-41906-3E3E2124 for ; Wed, 16 Feb 2005 01:10:44 -0500 Received: from foxbox (IGLD-83-130-23-99.inter.net.il [83.130.23.99]) by gw2.emini.dk (Postfix) with ESMTP id 4FB00505A0; Wed, 16 Feb 2005 07:10:39 +0100 (CET) Message-ID: <003f01c513ee$3ff174a0$6402a8c0@foxbox> Reply-To: "Steph" To: "Ilia Alshanetsky" , "Andi Gutmans" Cc: "Jani Taskinen" , References: <5.1.0.14.2.20050215142521.0214d340@localhost><4212B78D.1010809@prohost.org> <5.1.0.14.2.20050215214736.021b4030@localhost> Date: Wed, 16 Feb 2005 08:10:42 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1158 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 Subject: Re: [PHP-DEV] [PATCH] Fix for bug #31440 (GLOBALS can beby G/P/Cwhen register_globals=On) From: steph@zend.com ("Steph") - I'd agree to that more if we didn't have barriers there already. But we do. Did you see the sitepoint blog today? - Steph ----- Original Message ----- From: "Andi Gutmans" To: "Steph" ; "Ilia Alshanetsky" Cc: "Jani Taskinen" ; Sent: Wednesday, February 16, 2005 7:48 AM Subject: Re: [PHP-DEV] [PATCH] Fix for bug #31440 (GLOBALS can beby G/P/Cwhen register_globals=On) > Yes because a lot of applications/code still use it. It's off by default > but we should still enable people to move to PHP 5 whilst allowing old code > to run. > > At 07:37 AM 2/16/2005 +0200, Steph wrote: > >Can anyone give me a good reason we still have register_globals in PHP 5 at > >all? > > > >I mean, it's been marked 'deprecated' forever.... > > > >Just my 2 sheks, > > > >- Steph > > > >----- Original Message ----- > >From: "Ilia Alshanetsky" > >To: "Andi Gutmans" > >Cc: "Jani Taskinen" ; > >Sent: Wednesday, February 16, 2005 5:01 AM > >Subject: Re: [PHP-DEV] [PATCH] Fix for bug #31440 (GLOBALS can be by > >G/P/Cwhen register_globals=On) > > > > > > > IMO this is something that should be marked as Won't Fix and hope that > > > by PHP 5.2 we can drop register_globals all together. Heck, perhaps we > > > can do it for PHP 5.1. > > > > > > Ilia > > > > > > Andi Gutmans wrote: > > > > This behavior makes some sort of sense. It happens when register_globals > > > > is on which means you are supposed to be able to access $GLOBALS[] and > > > > it makes sense for it to stay in sync with the global variables. > > > > Maybe $GLOBALS[] and $GLOBALS direct access are edge cases but should we > > > > invest time and code to resolve this when we know it's a general problem > > > > anyway? > > > > > > > > Andi > > > > > > > > At 01:39 PM 2/15/2005 +0200, Jani Taskinen wrote: > > > > > > > >> Patch to fix is here: > > > >> > > > >> http://www.php.net/~jani/patches/bug31440.php_4_3_patch > > > >> http://www.php.net/~jani/patches/bug31440.php_HEAD_patch > > > >> > > > >> In PHP_4_3 you can overwrite GLOBALS with these queries: > > > >> > > > >> ?GLOBALS[foo]=err or ?GLOBALS[]=foo or ?GLOBALS=foo > > > >> > > > >> In HEAD you can overwrite GLOBALS with this only: > > > >> > > > >> ?GLOBALS=foo > > > >> > > > >> I didn't investigate WHY that is the only type of query that > > > >> "works" in HEAD branch but the same patch fixed that too. > > > >> > > > >> None of super-globals can be overwritten like this, be it > > > >> register_globals On or Off. > > > >> > > > >> IMNSHO, GLOBALS should be "protected". > > > >> (I don't say that this hacky patch of mine is the way, but it does > > > >> the job :) > > > >> > > > >> --Jani > > > >> > > > >> -- > > > >> PHP Internals - PHP Runtime Development Mailing List > > > >> To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > > > > > > > > > -- > > > PHP Internals - PHP Runtime Development Mailing List > > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >