Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:14919 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72911 invoked by uid 1010); 14 Feb 2005 16:29:29 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 72896 invoked from network); 14 Feb 2005 16:29:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Feb 2005 16:29:29 -0000 X-Host-Fingerprint: 195.141.85.118 uf2.search.ch Linux 2.4/2.6 Received: from ([195.141.85.118:54805] helo=xaxa.search.ch) by pb1.pair.com (ecelerity 1.2.11 (r4403)) with SMTP id 3E/71-18098-7E1D0124 for ; Mon, 14 Feb 2005 11:29:28 -0500 Received: from localhost (localhost [127.0.0.1]) by xaxa.search.ch (Postfix) with ESMTP id DCB456D8B8; Mon, 14 Feb 2005 17:29:18 +0100 (CET) Received: by xaxa.search.ch (Postfix, from userid 65534) id 98E3C6D8AC; Mon, 14 Feb 2005 17:29:17 +0100 (CET) Received: from [192.168.1.72] (ultrafilter2-i [192.168.85.3]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by xaxa.search.ch (Postfix) with ESMTP id 2DCB86CFBC; Mon, 14 Feb 2005 17:29:17 +0100 (CET) Message-ID: <4210D1DC.60901@cschneid.com> Date: Mon, 14 Feb 2005 17:29:16 +0100 User-Agent: Mozilla Thunderbird 1.0 (X11/20041207) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ante Drnasin Cc: internals@lists.php.net References: <20050214091449.761.qmail@lists.php.net> In-Reply-To: <20050214091449.761.qmail@lists.php.net> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on xaxa.search.ch X-Spam-Level: X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.64 X-Virus-Scanned: by AMaViS 0.3.12pre8 Subject: Re: php suggestion From: cschneid@cschneid.com (Christian Schneider) Hey Ante, Ante Drnasin wrote: > I would just like to hear you oppinions about something like > this...(please don't shoot me :) ) > > ex1: > function AddToDb(mysql_scape_string($text)) { I'd say it's not too useful but opens up a can of worms: - You're adding code to a declaration, IMHO confusing - How complicated code is allowed, e.g. what happens with function foo(bar($p1, $p2)) { or function foo($p2->bar($p1), $p1->bar($p2)) { I think we should keep the language simple and stay with $text = mysql_scape_string($text); at the beginning of the function. That way everybody understands what's going on. - Chris