Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:14886 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85567 invoked by uid 1010); 12 Feb 2005 22:40:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 85543 invoked from network); 12 Feb 2005 22:40:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Feb 2005 22:40:41 -0000 X-Host-Fingerprint: 217.160.92.50 geburtsjahr.neunzehnhunderteinundachtzig.de Linux 2.4/2.6 Received: from ([217.160.92.50:38251] helo=geburtsjahr.neunzehnhunderteinundachtzig.de) by pb1.pair.com (ecelerity 1.2.11 (r4403)) with SMTP id 4E/25-04303-8E58E024 for ; Sat, 12 Feb 2005 17:40:40 -0500 Received: from bauernhof (p3E9EC5DA.dip.t-dialin.net [62.158.197.218]) by geburtsjahr.neunzehnhunderteinundachtzig.de (Postfix) with ESMTP id 4D7D09192; Sat, 12 Feb 2005 23:42:21 +0100 (CET) Received: from sparkasse (unknown [192.168.1.7]) by bauernhof (Postfix) with ESMTP id 7402C630EC; Sat, 12 Feb 2005 23:40:09 +0100 (CET) To: Marcus Boerger Date: Sat, 12 Feb 2005 23:39:30 +0100 User-Agent: KMail/1.7.1 Cc: "David Kingma | jool.nl" , 'Andi Gutmans' , 'Sean Coates' , 'Ante Drnasin' , internals@lists.php.net References: <5.1.0.14.2.20050211142333.02095c00@localhost> <510367282.20050212184522@marcus-boerger.de> <648218084.20050212185805@marcus-boerger.de> In-Reply-To: <648218084.20050212185805@marcus-boerger.de> Organization: Mayflower GmbH MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-ID: <200502122339.31396.schlueter@mayflower.de> Subject: Re: [PHP-DEV] Autoboxing in php 5.1 From: schlueter@mayflower.de (Johannes Schlueter) Hi Marcus, On Saturday 12 February 2005 18:58, Marcus Boerger wrote: > ups, reading again i see it, it was ReflectionProperty::getDocComment() > > Johannes had a patch for that already and i asked for it some months ago > but i don't remember if there was anything against it. no, the some-months-old-and-not-committed-patch from me is=20 ReflectionProperty::getLinenumber() (see [1]) But meanwhile I had a look on= =20 the implementation of the other getDocComment stuff and found that the=20 current implementation has problems with methods/classes with no own=20 doc_comment but following some irrelevant doc_comment (see [2]) so I'm=20 currently thinking wether I need to make all the getDocComment related stuf= f=20 work without CG(doc_comment) or wether it's enough to free the=20 CG(doc_comment) and CG(doc_comment_len) more often... btw. it would also need either a reflectionClass::getConstantDocComment(str= ing=20 $name) or some ReflectionConstant class to complete the api (in no way need= ed=20 to create WSDL files but for reflecting classes...), in the later case one= =20 could also implement ReflectionClass::getLinenumber(),=20 ReflectionConstant::getDeclaringClass() and such stuff. While writing this mail I did some deeper look on the getDocComment stuff a= nd=20 found that my "it doesn't work example"[2] was the only case it doesn't wor= k=20 =2D just adding some statement behind the comment frees the buffer, so it's= =20 still a bug but one that should only happen in rare situations, so let's se= e=20 how to fix this and get all required doc_comments. This all said I don't think the current docComment stuff is enough to creat= e=20 some WSDL file in a nice way[tm]. Therefore ext/soap at least needs the=20 parsed docblock or meta-data from somewhere else (like typehints...) johannes [1] http://news.php.net/php.internals/14590 [2] http://schlueters.de/getdoccomment.phpt =2D-=20 Johannes Schl=FCter Mayflower GmbH Tel.: +49 89 24 20 54 33 Sendliger Str.42a =46ax : +49 89 24 20 54 29 D-80331 M=FCnchen=20 schlueter@mayflower.de http://mayflower.de