Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:14885 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67125 invoked by uid 1010); 12 Feb 2005 20:54:30 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 67092 invoked from network); 12 Feb 2005 20:54:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Feb 2005 20:54:30 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.4/2.6 Received: from ([80.74.107.235:39849] helo=mail.zend.com) by pb1.pair.com (ecelerity 1.2.11 (r4403)) with SMTP id 74/02-04303-40D6E024 for ; Sat, 12 Feb 2005 15:54:29 -0500 Received: (qmail 2481 invoked from network); 12 Feb 2005 20:54:21 -0000 Received: from internal.zend.office (HELO armada) (10.1.1.1) by internal.zend.office with SMTP; 12 Feb 2005 20:54:21 -0000 Date: Sat, 12 Feb 2005 23:44:26 +0300 To: Jani Taskinen Cc: internals@lists.php.net Message-ID: <20050212234426.5ef28675.antony@zend.com> In-Reply-To: References: <20050212201323.0e1e6328.antony@zend.com> X-Mailer: Sylpheed version 1.0.1 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] fix for bug #31455 (multiple session_start() creates multiple session cookies in HTTP-Response) From: antony@zend.com (Antony Dovgal) On Sat, 12 Feb 2005 20:03:37 +0200 (EET) Jani Taskinen wrote: > On Sat, 12 Feb 2005, Antony Dovgal wrote: > > > Does anyone object to this fix merged into all branches ? > > > > http://tony2001.phpclub.net/dev/tmp/bug31455.diff > > > > What's the difference with PS(cookie_send) and PS(sent_cookie) ?? PS(send_cookie) is used to determine if we need to set cookie when client didn't send it to the server. PS(cookie_sent) it turn is required to eliminate miltiple cookies to be set. Jani, I know that ext/session is a collection of hacks. But IMO this doesn't mean that we should not fix bugs there (and yes, I think the current behaviour looks more like a bug). This doesn't mean that I'm going to commit the fix if you do strongly object, though =) -- Wbr, Antony Dovgal aka tony2001