Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:14818
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Fri, 11 Feb 2005 04:45:46 +0200 (EET)
Reply-To: Jani Taskinen <sniper@iki.fi>
To: Andi Gutmans <andi@zend.com>
Cc: internals@lists.php.net
In-Reply-To: <5.1.0.14.2.20050210150822.01d3f6e0@localhost>
Message-ID: <Pine.LNX.4.61.0502110416120.31271@arfg.argcubovn.sv>
References: <5.1.0.14.2.20050210150822.01d3f6e0@localhost>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: TSRM(PHP_4_3) / TSRM.c
	TSRM.h tsrm_config.nw.h tsrm_config_common.h tsrm_nw.c tsrm_nw.h tsrm_virtual_cwd.c
	tsrm_virtual_cwd.h tsrm_win32.c tsrm_win32.h  
From: sniper@iki.fi (Jani Taskinen)

On Thu, 10 Feb 2005, Andi Gutmans wrote:

> Jani,
>
> This looks like a very serious change for 4.3.x series. It should really be 
> discussed on internals@ before you fire away.

     Sure, let's discuss. This is the only way to get any attention to
     anything anyway. Just to note first of all that I asked Ilia (who was the release
     god for PHP_4_3 last time I checked..) and he didn't object to syncing HEAD
     TSRM as long as it's fixes only.

     And it does fix a lot: There are no more leaks in ZTS mode.
     Plus it's actually maintainable now when all those whitespace changes, etc.
     are in the PHP_4_3 branch too.

> There was also agreement a while ago that realpath caching will only be in 
> 5.1.x so that it gets enough testing.

     AFAICT, it's not enabled in HEAD nor it is enabled in PHP_4_3 so I don't
     really see any problems there.

> Also as most of these fixes are Netware/Windows related, I don't think it's 
> worth the risk of crashes and other problems we said we might have with some 
> of the changes.

     Which change are you referring to here? (And I wouldn't worry about netware here..)

     --Jani