Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:14794 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89362 invoked by uid 1010); 10 Feb 2005 13:22:10 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 88940 invoked from network); 10 Feb 2005 13:21:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Feb 2005 13:21:49 -0000 X-Host-Fingerprint: 195.197.172.115 gw01.mail.saunalahti.fi Linux 2.4/2.6 Received: from ([195.197.172.115:42236] helo=gw01.mail.saunalahti.fi) by pb1.pair.com (ecelerity HEAD (r4105:4106)) with SMTP id 82/4C-10493-CEF5B024 for ; Thu, 10 Feb 2005 08:21:48 -0500 Received: from nest.netphobia.fi (YZCLXVIII.dsl.saunalahti.fi [85.76.34.69]) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id F2A07D3866; Thu, 10 Feb 2005 15:21:44 +0200 (EET) Received: from nest.netphobia.fi (nest.netphobia.fi [127.0.0.1]) by nest.netphobia.fi (8.13.1/8.13.1) with ESMTP id j1ADLkDV020150; Thu, 10 Feb 2005 15:21:46 +0200 Received: from localhost (jani@localhost) by nest.netphobia.fi (8.13.1/8.13.1/Submit) with ESMTP id j1ADLk1f020147; Thu, 10 Feb 2005 15:21:46 +0200 X-Authentication-Warning: nest.netphobia.fi: jani owned process doing -bs Date: Thu, 10 Feb 2005 15:21:45 +0200 (EET) Reply-To: Jani Taskinen To: Joe Orton Cc: internals@lists.php.net In-Reply-To: <20050209105920.GA3959@redhat.com> Message-ID: References: <20050209105920.GA3959@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [PHP-DEV] [PATCH] install ext/gd headers From: sniper@iki.fi (Jani Taskinen) While this patch works fine, what if you don't actually have GD installed in your PHP? There should be a configure macro that adds the headers when really needed.. --Jani On Wed, 9 Feb 2005, Joe Orton wrote: > We had a request to install the ext/gd headers, which are needed to > compile the pdflib extension. Any objections? I've tested this to at > least build the PECL pdflib module. > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=145891 > > Index: scripts/Makefile.frag > =================================================================== > RCS file: /repository/php-src/scripts/Makefile.frag,v > retrieving revision 1.14 > diff -u -r1.14 Makefile.frag > --- scripts/Makefile.frag 20 Jan 2005 01:41:20 -0000 1.14 > +++ scripts/Makefile.frag 9 Feb 2005 10:56:46 -0000 > @@ -38,6 +38,8 @@ > main/ \ > main/streams/ \ > regex/ \ > + ext/gd/ \ > + ext/gd/libgd/ \ > ext/iconv/ \ > ext/libxml/ \ > ext/standard/ \ > >