Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:14635
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 3 Feb 2005 21:07:42 -0700
Message-ID: <5367F26C013DE8429873569307F6F4A3BC27B5@OCC01MX023.na.simplot.com>
Thread-Topic: [PHP-DEV] [PATCH] Bug# 27633 - Wrong translation in ASCII mode
Thread-Index: AcUJap+N6uU9bw3kRYCbTCiykgruuQAE2ahQADVjZqA=
To: <internals@lists.php.net>
Subject: RE: [PHP-DEV] [PATCH] Bug# 27633 - Wrong translation in ASCII mode
From: Jesse.Binam@simplot.com ("Binam, Jesse")

Can someone *please* review and commit this patch.
http://www.binam.net/bug-27633.patch

Scope: PHP4 & PHP5 on windows
Overview: Some ftp servers send a '\r' before every '\n' when
transferring in ASCII mode. If the file being retrieved has windows
flavor line endings '\r\n', the resulting file ends up with '\r\r\n'
line endings. This patch fixes that problem.=20

I am not trying to be obstinate or make any enemies, just please just
hear me out. I for one use PHP for batch scripting in an enterprise
production environment. It works extremely well in this context. It's
numerous extensions and other features provide a very robust, cross
platform environment comparable to Perl without the bloat. I can hack
together entire process flows very quickly and with better efficiency
than using something like bash. Not mention that a simple PHP/iODBC
install, and a couple kb of base code, provides an open source ETL
platform that IMO is more flexible and able than most commercial ETL
packages.

But regardless of what I happen to be doing I have to be able to rely on
the integrity of the data. I understand that the root of the wierdness
associated with this bug is caused by the remote server munging the data
and not PHP. But it is on the client to properly handle ASCII
translation for FTP transfers. So if I am on a windows box and I specify
that I want an ASCII transfer then I have to assume that it is being
done correctly and my resulting file will have '\r\n' line endings. If I
can't that rates as a critical bug in my book.

I know I am new here and therefore my posts are probably ignored by the
majority of the key players on this list. I am also not a very
experienced C coder and I expect to get some flack for it when I put my
code out there for public review. But rather than whine and send hate
mail because nobody will fix it for me, I took the time to fix it and
test it the best I can. All I am asking that someone with commit access
take the time to review the patch and either commit it so that the rest
of the user community can benefit from it or tell me in no uncertain
terms what I am doing wrong that makes it unacceptable so I can work on
it. The more input I can get from the internals gods the better my code
will be and the better I will understand the internals to the best
language ever conceived. And who knows maybe I will be a major
contributor to PHP50. Isn't that what the open source community is
about?

I have it coming now don't I. :/