Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:1447
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Mon, 12 May 2003 22:27:17 +0900
MIME-Version: 1.0
To: php-internal <internals@lists.php.net>
Message-ID: <20030512222717w!4#MP@at.wakwak.com>
Content-Type: multipart/mixed; boundary="------------Boundary_=OYj.Gz)df:vWv"
Subject: Patch for OnUpdateBool in zend_ini.c
From: moriyoshi@at.wakwak.com (Moriyoshi Koizumi)

--------------Boundary_=OYj.Gz)df:vWv
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi,

I just found OnUpdateBool ini handler is not working properly at the 
moment.

<quote>
ZEND_API ZEND_INI_MH(OnUpdateBool)
{
    zend_bool *p;
#ifndef ZTS
    char *base = (char *) mh_arg2;
#else
    char *base;

    base = (char *) ts_resource(*((int *) mh_arg2));
#endif

    p = (zend_bool *) (base+(size_t) mh_arg1);

    if (strncasecmp("on", new_value, sizeof("on"))) {
        *p = (zend_bool) atoi(new_value);
    } else {
        *p = (zend_bool) 1;
    }
    return SUCCESS;
}
</quote>

IMO, this part

    if (strncasecmp("on", new_value, sizeof("on"))) {
        *p = (zend_bool) atoi(new_value);
    } else {
        *p = (zend_bool) 1;
    }

should be 

    if (new_value_length == sizeof("on") -1 &&
        strcasecmp("on", new_value) == 0) {
		*p = (zend_bool) 1;
	} else {
        *p = (zend_bool) atoi(new_value);
	}

Otherwise you can set the corresponding entry to 1 if you specify
a single letter "o" for it.

The patch is attached.

Moriyoshi

--------------Boundary_=OYj.Gz)df:vWv
Content-Type: text/plain; name="zend-ini-patch.diff.txt"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="zend-ini-patch.diff.txt"

SW5kZXg6IFplbmQvemVuZF9pbmkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvcmVwb3Np
dG9yeS9aZW5kRW5naW5lMi96ZW5kX2luaS5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjMw
CmRpZmYgLXUgLXIxLjMwIHplbmRfaW5pLmMKLS0tIFplbmQvemVuZF9pbmkuYwkyNCBNYXIg
MjAwMyAxNDo1MzozMCAtMDAwMAkxLjMwCisrKyBaZW5kL3plbmRfaW5pLmMJMTIgTWF5IDIw
MDMgMTM6MjM6MDMgLTAwMDAKQEAgLTQzMSwxMCArNDMxLDEwIEBACiAKIAlwID0gKHplbmRf
Ym9vbCAqKSAoYmFzZSsoc2l6ZV90KSBtaF9hcmcxKTsKIAotCWlmIChzdHJuY2FzZWNtcCgi
b24iLCBuZXdfdmFsdWUsIHNpemVvZigib24iKSkpIHsKLQkJKnAgPSAoemVuZF9ib29sKSBh
dG9pKG5ld192YWx1ZSk7CisJaWYgKG5ld192YWx1ZV9sZW5ndGggPT0gc2l6ZW9mKCJvbiIp
IC0gMSAmJiBzdHJjYXNlY21wKCJvbiIsIG5ld192YWx1ZSkgPT0gMCkgeworCQkqcCA9ICh6
ZW5kX2Jvb2wpIDE7IAogCX0gZWxzZSB7Ci0JCSpwID0gKHplbmRfYm9vbCkgMTsKKwkJKnAg
PSAoemVuZF9ib29sKSBhdG9pKG5ld192YWx1ZSk7CiAJfQogCXJldHVybiBTVUNDRVNTOwog
fQo=

--------------Boundary_=OYj.Gz)df:vWv--