Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:14420
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Mon, 24 Jan 2005 06:44:24 +0200 (EET)
Reply-To: Jani Taskinen <sniper@iki.fi>
To: "Carter, John" <John.Carter@royal-london.co.uk>
Cc: internals@lists.php.net
In-Reply-To: <5A9A683C389FE34AB92155BB46D0D20B01C4D630@2krlwwex02.royallondon.royallondongroup.com>
Message-ID: <Pine.LNX.4.61.0501240642060.3682@ybpnyubfg.ybpnyqbznva>
References: <5A9A683C389FE34AB92155BB46D0D20B01C4D630@2krlwwex02.royallondon.royallondongroup.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [PHP-DEV] Patch for bug 29334 Daylight Savings Win32
From: sniper@iki.fi (Jani Taskinen)


     This "fix" is not very ideal considering this note about tm_isdst property:

       "Positive value if daylight saving time is in effect; 0 if daylight
       saving time is not in effect; negative value if status of daylight
       saving time is unknown. If the TZ environment variable is set, the C
       run-time library assumes rules appropriate to the United States for
       implementing the calculation of daylight-saving time (DST)."

     In case the status of dst is unknown, you'd be removing 1 or more
     hours from the time..

     --Jani

     p.s. I removed this patch from the bug report.


On Fri, 14 Jan 2005, Carter, John wrote:

> Hi,
>
> This bug's been open a while (since July). I placed a small patch in the comments in October (repeated below); can someone review and commit please?
>
> John.
>
> patch to win32 sendmail.c:
>
> --- old.c	2004-09-08 21:33:17.640625000 +0100
> +++ new.c	2004-09-08 21:39:06.890625000 +0100
> @@ -684,6 +684,7 @@
> 	}
> 	zoneh /= (60 * 60);
> 	zonem = (abs(_timezone) / 60) - (zoneh * 60);
> +	zoneh += tm->tm_isdst;
>
>
> 	if(!xheaders || !strstr(headers_lc, "date:")){
>
>
> John Carter
> Developer, Integro project
> Royal London
> (44) 1625 605735
> john.carter@royal-london.co.uk
>
>
>
> The contents of this e-mail are confidential and for the addressee only.
> If you are not the addressee you should not print, copy or distribute
> this e-mail or use it or its contents or copy or publish its contents
> to any other person.  If you have received this e-mail in error please
> notify us and delete it from your system.
>
> The Royal London Mutual Insurance Society Limited for life and pension
> products. Registered in England No. 99064. Registered Office:
> 55 Gracechurch Street, London, EC3V 0RL. Royal London Asset Management Limited
> for investment management services. Registered in England No. 2244297.
> Registered Office: 55 Gracechurch Street, London, EC3V 0UF.
> Royal London Savings Limited for Individual Savings Accounts.
> Registered in England No. 3642633. Registered Office: 55 Gracechurch Street,
> London, EC3V 0RL. Royal London Unit Trust Managers Limited
> for unit trusts. Registered in England No. 2372439.
> Registered Office: 55 Gracechurch Street, London, EC3V 0UF.
> All these companies are authorised and regulated by the Financial Services Authority.
>
>