Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:14272
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
Cc: internals@lists.php.net
To: derick@php.net
Date: Tue, 04 Jan 2005 00:07:04 -0800
Message-ID: <1104826024.21222.211948578@webmail.messagingengine.com>
Subject: vsprintf returns int not char*
From: kameshj@fastmail.fm ("Kamesh Jayachandran")

Hi Derick,
in php-src/main/php_sprintf.c
PHPAPI int
php_sprintf (char*s, const char* format, ...)
{
  va_list args;
  char *ret; //ret should be of type integer as vsprintf returns int
  rather than char*

  va_start (args, format);
  s[0] = '\0';
  ret = vsprintf (s, format, args);
  va_end (args);
  if (!ret) //This check should be if(ret < 0) as ret will have the
  number of characters printed to s  
//If an output error is encountered, a negative  value  is returned.
    return -1;
  return strlen (s);
}
ret should be of type integer as vsprintf returns int rather than char*.
if (!ret) should be if(ret < 0)


With regards
Kamesh Jayachandran