Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:14239 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37239 invoked by uid 1010); 30 Dec 2004 10:03:40 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 37207 invoked from network); 30 Dec 2004 10:03:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Dec 2004 10:03:40 -0000 X-Host-Fingerprint: 217.69.76.213 hermes.e-matters.de Linux 2.4/2.6 Received: from ([217.69.76.213:54753] helo=e-matters.de) by pb1.pair.com (ecelerity HEAD (r3992M)) with SMTP id 2C/E3-65170-A32D3D14 for ; Thu, 30 Dec 2004 05:02:35 -0500 Received: (qmail 27365 invoked by uid 0); 30 Dec 2004 09:59:13 -0000 Received: from p508d63fe.dip.t-dialin.net (HELO ?192.168.1.77?) (80.141.99.254) by /var/run/qmail-smtp.pid with SMTP; 30 Dec 2004 09:59:13 -0000 Message-ID: <41D3D235.4000409@php.net> Date: Thu, 30 Dec 2004 11:02:29 +0100 User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ron Korving CC: internals@lists.php.net References: <20041228154459.29637.qmail@pb1.pair.com> <5.1.0.14.2.20041229174350.02ed81c0@localhost> <20041230082737.30176.qmail@pb1.pair.com> In-Reply-To: <20041230082737.30176.qmail@pb1.pair.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] base64_encode() memory issue From: sesser@php.net (Stefan Esser) Hello, this issue was already cleared as bogus safe_emalloc already takes care of the one extra byte that should get added. safe_emalloc does allocate param1 * param2 + param3 bytes > result = (unsigned char *)safe_emalloc(((length + 2) / 3) * 4, sizeof(char), > 1); > > would become > > result = (unsigned char *)safe_emalloc(((length + 2) / 3) * 4 + 1, > sizeof(char), 1); Stefan