Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:14238 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 31617 invoked by uid 1010); 30 Dec 2004 08:29:04 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 31565 invoked by uid 1007); 30 Dec 2004 08:29:03 -0000 Message-ID: <20041230082903.31564.qmail@pb1.pair.com> To: internals@lists.php.net References: <20041228154459.29637.qmail@pb1.pair.com> <5.1.0.14.2.20041229174350.02ed81c0@localhost> Date: Thu, 30 Dec 2004 09:28:56 +0100 Lines: 41 X-Priority: 3 X-MSMail-Priority: Normal X-Newsreader: Microsoft Outlook Express 6.00.2800.1437 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1441 X-Posted-By: 62.58.68.2 Subject: Re: [PHP-DEV] base64_encode() memory issue From: r.korving@xit.nl ("Ron Korving") Forgot to add that in my specific case valgrind mentioned an illegal read and write of 1 byte. Ron "Andi Gutmans" schreef in bericht news:5.1.0.14.2.20041229174350.02ed81c0@localhost... > Do you have a patch which you think should be applied? If not, can you send > a reproducing script (a short one). Maybe you want to run it through > valgrind and see where the damage is done. > > Andi > > At 04:44 PM 12/28/2004 +0100, Ron Korving wrote: > >Hi, > > > >I'm not sure how to test what I noticed, so I figured I would post this here > >and see if any of you could test it and see if I'm correct. When I test this > >in a non-PHP environment with malloc(), this does present a problem however, > >and when running segfaults randomly appear because of it. > > > >In base64.c, the string is closed with a \0 byte, but this one byte is never > >allocated. Since it's just 1 byte, this often happens without causing > >trouble, but every once in a while it does cause a segfault. I hope someone > >can confirm this. > > > >Happy holidays, > > > >Ron > > > >-- > >PHP Internals - PHP Runtime Development Mailing List > >To unsubscribe, visit: http://www.php.net/unsub.php