Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:14236 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36095 invoked by uid 1010); 30 Dec 2004 03:51:24 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 35999 invoked from network); 30 Dec 2004 03:51:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Dec 2004 03:51:22 -0000 X-Host-Fingerprint: 64.233.184.193 wproxy.gmail.com Linux 2.4/2.6 Received: from ([64.233.184.193:58440] helo=wproxy.gmail.com) by pb1.pair.com (ecelerity HEAD (r3992M)) with SMTP id 46/A3-65170-83B73D14 for ; Wed, 29 Dec 2004 22:51:20 -0500 Received: by wproxy.gmail.com with SMTP id 36so212697wri for ; Wed, 29 Dec 2004 19:51:14 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=Ry+DM2ySg1yGv2BzVZ3T/0k14qGA/Y6ytMOFdSmVlgeeWzX1ZmDkptweOsvpxeRO+DXitKroLYo0YK5t8mB1aBjf1+smoLJGthA6DwytEQM9+VhZG7NEcPC+ugwO7SWpYDYpHIs3B92YNXDhmfdvCXnUl01gDJvMQl2v84TtQxA= Received: by 10.54.19.64 with SMTP id 64mr177831wrs; Wed, 29 Dec 2004 19:51:14 -0800 (PST) Received: by 10.54.59.28 with HTTP; Wed, 29 Dec 2004 19:51:14 -0800 (PST) Message-ID: <4e89b42604122919514dd2c4f8@mail.gmail.com> Date: Wed, 29 Dec 2004 22:51:14 -0500 Reply-To: Wez Furlong To: Andi Gutmans Cc: internals , Stanislav Malyshev In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <4e89b42604122419221cb6e085@mail.gmail.com> Subject: Re: [PHP-DEV] Re: broken fix? From: kingwez@gmail.com (Wez Furlong) This bug is critical for 4.3.11, and has repercussions for any extension with overloaded objects, not just COM. --Wez. On Sat, 25 Dec 2004 15:48:26 +0200 (IST), Stanislav Malyshev wrote: > Did you look into my latest patch and try with it? The tip of the 4.3 branch is still broken; and I don't see any changes in CVS either before or after the commit I mentioned--did you forget to commit something? WF>>http://viewcvs.php.net/viewcvs.cgi/Zend/Attic/zend_execute.c.diff?r1=1.316.2.41&r2=1.316.2.42&hideattic=0 > WF>> > WF>>fix overloaded calls not returning result, e.g.: > WF>> > WF>> > WF>>is to blame. > WF>> > WF>>If you counter-act the unlock in the COM call handler (setting is_ref > WF>>and bumping the refcount), things work "fine". This is a hack, so I'm > WF>>hoping that you engine gurus will divine the correct fix. > > I think the is_ref thing is the key, see above. I'll check with your > example on Sunday.