Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:14015 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 34663 invoked by uid 1010); 8 Dec 2004 00:37:26 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 34239 invoked from network); 8 Dec 2004 00:37:22 -0000 Received: from unknown (HELO mail.zend.com) (80.74.107.235) by pb1.pair.com with SMTP; 8 Dec 2004 00:37:22 -0000 Received: (qmail 25534 invoked from network); 8 Dec 2004 00:37:20 -0000 Received: from localhost (HELO andi-notebook.zend.com) (127.0.0.1) by localhost with SMTP; 8 Dec 2004 00:37:20 -0000 Message-ID: <5.1.0.14.2.20041207163632.02b15e20@localhost> X-Sender: andi@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Tue, 07 Dec 2004 16:37:17 -0800 To: Georg Richter ,internals@lists.php.net In-Reply-To: <1102090473.15050.261.camel@beethoven.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Bug fix for #28817 - different behaviour in HEAD and 5_0 From: andi@zend.com (Andi Gutmans) References: <1102090473.15050.261.camel@beethoven.local> Hi Georg, When we nuked the garbage collector this behavior was accidentally changed. I think it should be fixed in the Zend Engine so that extensions stay source compatible in between versions as much as possible. Will look into it. Thanks, Andi At 05:14 PM 12/3/2004 +0100, Georg Richter wrote: >Hi, > >the following patch solves bug #28817 in HEAD. >However it doesn't work in 5_0 branch. In 5_0 I have to set >retval->refcount to 1 to get it work - any ideas what's going wrong ?! > >Same behaviour in mysqli (which has a similiar property handling). > >/Georg > >Patch: > >diff -u -r1.64 php_dom.c >--- php_dom.c 7 Oct 2004 11:40:20 -0000 1.64 >+++ php_dom.c 3 Dec 2004 13:49:25 -0000 >@@ -235,6 +235,7 @@ > } else { > std_hnd = zend_get_std_object_handlers(); > retval = std_hnd->read_property(object, member, type >TSRMLS_CC); >+ retval->refcount = 0; > } > > if (member == &tmp_member) { > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php