Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13996
Return-Path: <georg@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 88763 invoked by uid 1010); 3 Dec 2004 16:15:38 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 85660 invoked from network); 3 Dec 2004 16:15:07 -0000
Received: from unknown (HELO mailgate.mysql.com) (213.136.52.47)
  by pb1.pair.com with SMTP; 3 Dec 2004 16:15:07 -0000
Received: from localhost (localhost.localdomain [127.0.0.1])
	by mailgate.mysql.com (8.12.10/8.12.10) with ESMTP id iB3GF61N001063
	for <internals@lists.php.net>; Fri, 3 Dec 2004 17:15:06 +0100
Received: from mail.mysql.com ([10.222.1.99])
 by localhost (mailgate.mysql.com [10.222.1.98]) (amavisd-new, port 10026)
 with LMTP id 31968-04 for <internals@lists.php.net>;
 Fri,  3 Dec 2004 17:15:06 +0100 (CET)
Received: from [192.168.0.40] (mailsend.mysql.com [10.100.1.123])
	(authenticated bits=0)
	by mail.mysql.com (8.12.10/8.12.10) with ESMTP id iB3GF3iM014884
	for <internals@lists.php.net>; Fri, 3 Dec 2004 17:15:04 +0100
To: internals@lists.php.net
Content-Type: text/plain
Message-ID: <1102090473.15050.261.camel@beethoven.local>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Fri, 03 Dec 2004 17:14:34 +0100
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by amavisd-new at mailgate.mysql.com
Subject: Bug fix for #28817 - different behaviour in HEAD and 5_0
From: georg@php.net (Georg Richter)

Hi,

the following patch solves bug #28817 in HEAD.
However it doesn't work in 5_0 branch. In 5_0 I have to set
retval->refcount to 1 to get it work - any ideas what's going wrong ?!

Same behaviour in mysqli (which has a similiar property handling).

/Georg

Patch:

diff -u -r1.64 php_dom.c
--- php_dom.c   7 Oct 2004 11:40:20 -0000       1.64
+++ php_dom.c   3 Dec 2004 13:49:25 -0000
@@ -235,6 +235,7 @@
        } else {
                std_hnd = zend_get_std_object_handlers();
                retval = std_hnd->read_property(object, member, type
TSRMLS_CC);
+               retval->refcount = 0;
        }

        if (member == &tmp_member) {