Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13935
Return-Path: <wmeler@wp-sa.pl>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 59660 invoked by uid 1010); 23 Nov 2004 12:05:05 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 59593 invoked from network); 23 Nov 2004 12:05:04 -0000
Received: from unknown (HELO mail.wp-sa.pl) (212.77.102.105)
  by pb1.pair.com with SMTP; 23 Nov 2004 12:05:04 -0000
Received: from [10.10.1.130] (it.wp-sa.pl [212.77.105.136])
 by mail.wp-sa.pl (iPlanet Messaging Server 5.2 HotFix 1.21 (built Sep  8
 2003)) with ESMTP id <0I7M009ZBS85HO@mail.wp-sa.pl> for
 internals@lists.php.net; Tue, 23 Nov 2004 13:04:53 +0100 (CET)
Date: Tue, 23 Nov 2004 13:04:53 +0100
To: internals@lists.php.net
Message-ID: <41A32765.7000105@wp-sa.pl>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-2; format=flowed
Content-transfer-encoding: 7BIT
X-Accept-Language: en-us, en
User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040803)
Subject: main/main.c - php_module_startup && additional modules
From: wmeler@wp-sa.pl (Wojtek Meler)

Hi !

I'm writing my own sapi module and I'd like register 2 additional 
modules calling php_module_startup.
I've noticed that it is imposible because

int php_module_startup(sapi_module_struct *sf, zend_module_entry 
*additional_modules, uint num_additional_modules)

is calling
php_startup_extensions(&additional_modules, num_additional_modules);

which signature is

int php_startup_extensions(zend_module_entry **ptr, int count)

php_startup_extensions expects array of pointers, while 
php_module_startup gets array of structures which is not convertable to
array of pointers in such way. It works only when num_additional_modules 
equals to 0 or 1.

how about adding

    zend_module_entry *start_extensions[num_additional_modules];
    for (i=0;i<num_additional_modules;i++) 
start_extensions[i]=&additional_modules[i];

and passing start_extensions instead of &additional_modules to 
php_startup_extensions ?
pros:
    - works fine,
    - no change in method signature
cons:
    - you have to build array of structures to pass it to 
php_startup_module while it is common to have single pointers to 
zend_module_entry structures

Of course it's better to change php_module_startup interface, while it 
is not often used. It would be easier to create array of pointers than 
copying
structs to single array. Any way something should be done.

Regards,
Wojtek