Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13869 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 356 invoked by uid 1010); 15 Nov 2004 17:46:21 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 166 invoked from network); 15 Nov 2004 17:46:20 -0000 Received: from unknown (HELO marvin.mindnever.org) (80.74.160.83) by pb1.pair.com with SMTP; 15 Nov 2004 17:46:20 -0000 Received: (qmail 6625 invoked by uid 509); 15 Nov 2004 18:37:10 -0000 Received: from bunuel-cpe-185-bgd.sbb.co.yu (HELO mravojed.office.kom) (82.117.196.185) by marvin.mindnever.org with SMTP; 15 Nov 2004 18:37:07 -0000 To: Derick Rethans Cc: internals@lists.php.net In-Reply-To: References: <1100531086.4084.9.camel@mravojed> <1100539460.4084.56.camel@mravojed> Content-Type: text/plain Organization: MindNever Dot Org Message-ID: <1100540776.4084.64.camel@mravojed> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Mon, 15 Nov 2004 18:46:17 +0100 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on leya.mindnever.org X-Spam-Level: X-Spam-Status: No, hits=-2.7 required=4.0 tests=AWL,BAYES_00,RCVD_IN_SBL, SUBJ_HAS_UNIQ_ID autolearn=no version=2.63 Subject: Re: [PHP-DEV] Fix for php4 bug #30096 From: vladimir@mindnever.org (Vladimir Zidar) On Mon, 2004-11-15 at 18:37, Derick Rethans wrote: > On Mon, 15 Nov 2004, Vladimir Zidar wrote: > > > But then whole function php_mktime() is wrong, as in case where gm=1, > > you expect that parameters you pass are GMT, and still you fill defaults > > with localtime. Also, later, if gm=1, timezone adjustment is in use, but > > with parameters that are in GMT. > > > > So the real good fix would be to remove timezone stuff completly out of > > there, and make another function in pair with php_localtime_r, that > > returns GMT, and to use it when gm=1. > > Sure, that's why I'm rewriting this stuff for PHP 5 ;-) I can see now that there is php_gmtime_r() function also. Can we use this when gm=1, and forget about timezone there ? I'll check now.