Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13868 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62485 invoked by uid 1010); 15 Nov 2004 17:37:09 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 62404 invoked from network); 15 Nov 2004 17:37:09 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 15 Nov 2004 17:37:09 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id iAFHb872008731 for ; Mon, 15 Nov 2004 18:37:08 +0100 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id iAFHb7lH008722; Mon, 15 Nov 2004 18:37:07 +0100 Date: Mon, 15 Nov 2004 18:37:06 +0100 (CET) X-X-Sender: derick@localhost To: Vladimir Zidar cc: internals@lists.php.net In-Reply-To: <1100539460.4084.56.camel@mravojed> Message-ID: References: <1100531086.4084.9.camel@mravojed> <1100539460.4084.56.camel@mravojed> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdimedia.nl Subject: Re: [PHP-DEV] Fix for php4 bug #30096 From: derick@php.net (Derick Rethans) On Mon, 15 Nov 2004, Vladimir Zidar wrote: > But then whole function php_mktime() is wrong, as in case where gm=1, > you expect that parameters you pass are GMT, and still you fill defaults > with localtime. Also, later, if gm=1, timezone adjustment is in use, but > with parameters that are in GMT. > > So the real good fix would be to remove timezone stuff completly out of > there, and make another function in pair with php_localtime_r, that > returns GMT, and to use it when gm=1. Sure, that's why I'm rewriting this stuff for PHP 5 ;-) regards, Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org