Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13809 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10076 invoked by uid 1010); 10 Nov 2004 16:07:07 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 9969 invoked from network); 10 Nov 2004 16:07:05 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 10 Nov 2004 16:07:05 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id iAAG75F7030250 for ; Wed, 10 Nov 2004 17:07:05 +0100 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id iAAG6x40030231; Wed, 10 Nov 2004 17:07:00 +0100 Date: Wed, 10 Nov 2004 17:06:56 +0100 (CET) X-X-Sender: derick@localhost To: "ilya77@gmail.com" cc: internals@lists.php.net In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdimedia.nl Subject: Re: [PHP-DEV] [PATCH] Bug #30743 - proc_close() causes a handle leak From: derick@php.net (Derick Rethans) On Wed, 10 Nov 2004, ilya77@gmail.com wrote: > Hi Guys, > > PHP_FUNCTION(proc_close) doesn't have a call to > CloseHandle(proc->child), to close the process handle. > This is causing a handle leak on Windows, and eventually brings the > whole OS to it's knees. > > Here's the fixed code snippet (there's a DIFF at the end of the file): Can you please post a unified diff without any whitespace changes (and put it online and provide a link, as gmail mangles files it seems). Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org