Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13742
Return-Path: <helly@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 57181 invoked by uid 1010); 6 Nov 2004 00:26:02 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 57133 invoked from network); 6 Nov 2004 00:26:02 -0000
Received: from unknown (HELO jan.prima.de) (83.97.50.139)
  by pb1.pair.com with SMTP; 6 Nov 2004 00:26:02 -0000
Received: from BAUMBART (p508EBF63.dip.t-dialin.net [::ffff:80.142.191.99])
  (IDENT: HydraIRC, AUTH: LOGIN tobi)
  by jan.prima.de with esmtp; Sat, 06 Nov 2004 00:24:27 +0000
Date: Sat, 6 Nov 2004 01:25:57 +0100
Reply-To: Marcus Boerger <helly@php.net>
X-Priority: 3 (Normal)
Message-ID: <132979735.20041106012557@marcus-boerger.de>
To: Tom Rogers <trogers@kwikin.com>
CC: internals@lists.php.net
In-Reply-To: <34391708.20041106101633@kwikin.com>
References: <418B4909.7010203@ailis.de>
 <255444644.20041105104900@marcus-boerger.de> <418B4FF6.4020503@ailis.de>
 <1306684207.20041105111518@marcus-boerger.de> <418B5929.30709@ailis.de>
 <34391708.20041106101633@kwikin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Upload Progress Meter Patch
From: helly@php.net (Marcus Boerger)

Hello Tom,

  can you please provide a unified diff (diff -u) which everyone here
  understands? Also it would help to see a diff against HEAD.

regards
marcus

Saturday, November 6, 2004, 1:16:33 AM, you wrote:

> Hi,

> Friday, November 5, 2004, 8:42:49 PM, you wrote:
KR>> Marcus Boerger wrote:
>>> Thinking about it another time you're right. So what the patch offers is
>>> all we can do. However having the session id available somehow would make
>>> the the patch usefull. 

KR>> I have some ideas for this. It may even be possible to remove the 
KR>> UPLOAD_IDENTIFIER-stuff from the patch and move it to the PHP extension.
KR>> This would make the patch more independant. The author of the PHP 
KR>> extension can decide how this variable is named and how it is transmitted.

KR>> If nobody has already a working solution I can give it a try this weekend.

KR>> But one question stays: Let's say that the PHP extension now knows the 
KR>> PHP session ID during progress tracking (because it was passed like the
KR>> UPLOAD_IDENTIFIER via a POST variable BEFORE the uploaded files). What 
KR>> can the extension do with it? Is it possible for this PHP extension to 
KR>> open the session, update variables in it, and close it again? Or is the
KR>> stage in which the callback is called to early for doing so?

> here are some changes I made to make a thread safe file upload. The diffs are
> against 4.3.8 but should be close enough. I am not an expert by any means but it
> may help




-- 
Best regards,
 Marcus                            mailto:helly@php.net