Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13722 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69521 invoked by uid 1010); 4 Nov 2004 13:40:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 69463 invoked from network); 4 Nov 2004 13:40:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by pb1.pair.com with SMTP; 4 Nov 2004 13:40:40 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iA4DeZDk002389 for ; Thu, 4 Nov 2004 08:40:40 -0500 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iA4DeYr24361 for ; Thu, 4 Nov 2004 08:40:35 -0500 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id iA4DeXrS024173 for ; Thu, 4 Nov 2004 13:40:33 GMT Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id iA4DeXbm024172 for internals@lists.php.net; Thu, 4 Nov 2004 13:40:33 GMT Date: Thu, 4 Nov 2004 13:40:33 +0000 To: internals@lists.php.net Message-ID: <20041104134033.GC23987@redhat.com> Mail-Followup-To: internals@lists.php.net Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: [PATCH] have "make test" with REPORT_EXIT_STATUS From: jorton@redhat.com (Joe Orton) Setting $REPORT_EXIT_STATUS no longer makes "make test" fail if any tests fail; is that deliberate or can it be fixed? Index: Makefile.global =================================================================== RCS file: /repository/php-src/Makefile.global,v retrieving revision 1.51 diff -u -r1.51 Makefile.global --- Makefile.global 4 Dec 2003 15:57:55 -0000 1.51 +++ Makefile.global 4 Nov 2004 13:39:51 -0000 @@ -51,7 +51,7 @@ install-su: install-pear install-tester test: - -@if test -x $(SAPI_CLI_PATH) && test ! -z $(SAPI_CLI_PATH); then \ + @if test -x $(SAPI_CLI_PATH) && test ! -z $(SAPI_CLI_PATH); then \ TEST_PHP_EXECUTABLE=$(top_builddir)/$(SAPI_CLI_PATH) \ TEST_PHP_SRCDIR=$(top_srcdir) \ CC="$(CC)" \