Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13534
Return-Path: <cschneid@cschneid.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 28876 invoked by uid 1010); 26 Oct 2004 18:39:42 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 26231 invoked from network); 26 Oct 2004 18:39:11 -0000
Received: from unknown (HELO xaxa.search.ch) (195.141.85.117)
  by pb1.pair.com with SMTP; 26 Oct 2004 18:39:11 -0000
Received: from localhost (localhost [127.0.0.1])
	by xaxa.search.ch (Postfix) with ESMTP
	id 1B64F6D8CA; Tue, 26 Oct 2004 20:08:30 +0200 (CEST)
Received: by xaxa.search.ch (Postfix, from userid 65534)
	id E10CE6D8C6; Tue, 26 Oct 2004 20:08:28 +0200 (CEST)
Received: from [192.168.1.72] (ultrafilter2-i [192.168.85.3])
	(using TLSv1 with cipher RC4-MD5 (128/128 bits))
	(No client certificate requested)
	by xaxa.search.ch (Postfix) with ESMTP
	id 731026CF9C; Tue, 26 Oct 2004 20:08:28 +0200 (CEST)
Message-ID: <417E929B.2040301@cschneid.com>
Date: Tue, 26 Oct 2004 20:08:27 +0200
User-Agent: Mozilla Thunderbird 0.8 (X11/20040913)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Rob Richards <rrichards@ctindustries.net>
Cc: internals@lists.php.net
References: <064a01c4bb82$8f9d4d90$f7dea8c0@cyberware.local>
In-Reply-To: <064a01c4bb82$8f9d4d90$f7dea8c0@cyberware.local>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on xaxa.search.ch
X-Spam-Level: 
X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham 
	version=2.64
X-Virus-Scanned: by AMaViS 0.3.12pre8
Subject: Re: streams file uri under windows
From: cschneid@cschneid.com (Christian Schneider)

Rob Richards wrote:
> Index: streams.c
> ===================================================================
> RCS file: /repository/php-src/main/streams/streams.c,v
> retrieving revision 1.68
> diff -r1.68 streams.c
> 1496c1496
> <   if (protocol && path[n+1] == '/' && path[n+2] == '/' && path[n+4] !=
> ':') {
> ---
> 
>>  if (protocol && path[n+1] == '/' && path[n+2] == '/' && path[n+4] != ':'
> 
> && path[n+3] != '/') {

I'm not an export on that piece of code but passing file:// to this 
function could cause problems.
You should at least move the path[n+3] != '/' to before the n+4 test and 
I think you should also make sure that n+3 is not '\0' as otherwise n+4 
could be beyond the end of the string, no?

Just my $.2,
- Chris