Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13517
Return-Path: <kingwez@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 71691 invoked by uid 1010); 26 Oct 2004 09:34:27 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 71135 invoked from network); 26 Oct 2004 09:34:23 -0000
Received: from unknown (HELO mproxy.gmail.com) (216.239.56.248)
  by pb1.pair.com with SMTP; 26 Oct 2004 09:34:23 -0000
Received: by mproxy.gmail.com with SMTP id w67so93345cwb
        for <internals@lists.php.net>; Tue, 26 Oct 2004 02:34:22 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
        b=cHqd+op4ySUDpHdslqy5COgyrZpU6PESiihdEJokqQxZzatPiOfd1ReLJlqGoOD39ePgIOoshEnbLl4i649XaExO9dJ+n1eNz8/To8TPbkzABexW9IYjakJVTuJCPmA+ARIZUssPtagV1dxowWcTNdZjomWxvKdaKxgkJYb1qC8=
Received: by 10.11.117.20 with SMTP id p20mr521560cwc;
        Tue, 26 Oct 2004 02:34:22 -0700 (PDT)
Received: by 10.11.117.13 with HTTP; Tue, 26 Oct 2004 02:34:19 -0700 (PDT)
Message-ID: <4e89b4260410260234523070c1@mail.gmail.com>
Date: Tue, 26 Oct 2004 10:34:19 +0100
Reply-To: Wez Furlong <kingwez@gmail.com>
To: Kamesh Jayachandran <kameshj@fastmail.fm>
Cc: internals@lists.php.net
In-Reply-To: <1098771439.4746.207262413@webmail.messagingengine.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <1098718837.4744.207207878@webmail.messagingengine.com>
	 <417D207D.3010605@thebrainroom.com>
	 <1098771439.4746.207262413@webmail.messagingengine.com>
Subject: Re: [PHP-DEV] Re: Why module shutdown function is not called for openssl extension?
From: kingwez@gmail.com (Wez Furlong)

Heh, looks like it's never ever been enabled since ext/openssl was born.

I committed your patch; the associated bug number was 29418.

Thanks :)

--Wez.


On Mon, 25 Oct 2004 23:17:19 -0700, Kamesh Jayachandran
<kameshj@fastmail.fm> wrote:
> Hi Wez,
> 
> zend_module_entry openssl_module_entry = {
>         STANDARD_MODULE_HEADER,
>         "openssl",
>         openssl_functions,
>         PHP_MINIT(openssl),
>         NULL, //supposed to be module shutdown function but marked as
>         NULL even though we have MSHUTDOWN function defined.
>         NULL,
>         NULL,
>         PHP_MINFO(openssl),
>         NO_VERSION_YET,
>         STANDARD_MODULE_PROPERTIES
> };
> 
> My patch for making the req.priv_key not to get dispopsed is available
> here.
> http://puggy.symonds.net/~kameshj/openssl.c.patch
> 
> With regards
> Kamesh Jayachandran
> On Mon, 25 Oct 2004 16:49:17 +0100, "Wez Furlong" <wez@thebrainroom.com>
> said:
> 
> 
> > Kamesh Jayachandran wrote:
> > > During the failure openssl_csr_new is not setting req.priv_key to NULL
> > > this causes dispose function to free the req.priv_key.
> >
> > > Can I go ahead and set req.priv_key = NULL when php_openssl_make_REQ
> > > returns failure and we_made_the_key == 0?
> >
> > Please send me a diff
> >
> > > I have seen shutdown function is set to NULL even though it is defined.
> >
> > Which one?  Where?
> >
> > --Wez
> >
> 
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
>