Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13515
Return-Path: <kameshj@fastmail.fm>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 12182 invoked by uid 1010); 26 Oct 2004 06:17:19 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 12128 invoked from network); 26 Oct 2004 06:17:19 -0000
Received: from unknown (HELO out2.smtp.messagingengine.com) (66.111.4.26)
  by pb1.pair.com with SMTP; 26 Oct 2004 06:17:19 -0000
Received: from web1.messagingengine.com (web1.internal [10.202.2.210])
	by frontend1.messagingengine.com (Postfix) with ESMTP id 0B6FCC349D1;
	Tue, 26 Oct 2004 02:17:19 -0400 (EDT)
Received: by web1.messagingengine.com (Postfix, from userid 99)
	id 2AD76896; Tue, 26 Oct 2004 02:17:19 -0400 (EDT)
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-Mailer: MIME::Lite 1.5  (F2.73; T1.001; A1.64; B3.05; Q3.03)
Cc: internals@lists.php.net
References: <1098718837.4744.207207878@webmail.messagingengine.com>
   <417D207D.3010605@thebrainroom.com>
In-Reply-To: <417D207D.3010605@thebrainroom.com>
To: "Wez Furlong" <wez@thebrainroom.com>
Date: Mon, 25 Oct 2004 23:17:19 -0700
X-Sasl-Enc: C1stfWxdOJZobElFEyMDdw 1098771439
Message-ID: <1098771439.4746.207262413@webmail.messagingengine.com>
Subject: Re: Why module shutdown function is not called for openssl extension?
From: kameshj@fastmail.fm ("Kamesh Jayachandran")

Hi Wez,

zend_module_entry openssl_module_entry = {
        STANDARD_MODULE_HEADER,
        "openssl",
        openssl_functions,
        PHP_MINIT(openssl),
        NULL, //supposed to be module shutdown function but marked as
        NULL even though we have MSHUTDOWN function defined.
        NULL,
        NULL,
        PHP_MINFO(openssl),
        NO_VERSION_YET,
        STANDARD_MODULE_PROPERTIES
};

My patch for making the req.priv_key not to get dispopsed is available
here.
http://puggy.symonds.net/~kameshj/openssl.c.patch

With regards
Kamesh Jayachandran
On Mon, 25 Oct 2004 16:49:17 +0100, "Wez Furlong" <wez@thebrainroom.com>
said:
> Kamesh Jayachandran wrote:
> > During the failure openssl_csr_new is not setting req.priv_key to NULL
> > this causes dispose function to free the req.priv_key.
> 
> > Can I go ahead and set req.priv_key = NULL when php_openssl_make_REQ
> > returns failure and we_made_the_key == 0?
> 
> Please send me a diff
> 
> > I have seen shutdown function is set to NULL even though it is defined.
> 
> Which one?  Where?
> 
> --Wez
>