Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13463
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Organization: Emini ApS
To: internals@lists.php.net
Date: Fri, 22 Oct 2004 16:02:55 +0200
User-Agent: KMail/1.6.2
Cc: Joe Orton <jorton@redhat.com>
References: <20041022062249.GA8983@redhat.com> <200410221426.50509.edink@emini.dk> <20041022134249.GA10577@redhat.com>
In-Reply-To: <20041022134249.GA10577@redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-ID: <200410221602.55723.edink@emini.dk>
Subject: Re: [PHP-DEV] _FILE_OFFSET_BITS=64 considered harmful
From: edink@emini.dk (Edin Kadribasic)

On Friday 22 October 2004 15:42, Joe Orton wrote:
> On Fri, Oct 22, 2004 at 02:26:50PM +0200, Edin Kadribasic wrote:
> > On Friday 22 October 2004 13:33, Joe Orton wrote:
> > > On Fri, Oct 22, 2004 at 12:59:04PM +0200, Edin Kadribasic wrote:
> > > > However I consider crashing apache children with signal 25 when doing
> > > > simple is_file() or fopen() on large files really harmful. Apache
> > > > flat out refuses to start if you have enabled php error log and that
> > > > file happen to be 2GB or bigger.
> > >
> > > For Linux at least that was fixed since 2.0.50, or are you using 1.3
> > > still?
> >
> > I still use 1.3 (like, I guess, most of the PHP installations outthere).
>
> Then consider this your official wake-up call :)

This is unrealistic. I'd rather have PHP working with my Apache 1.3 without 
crashing it. 

So so far _FILE_OFFSET_BITS=64 fixes one crash, makes is_*() functions work, 
allows opening an writing large files. On the downside it creates binary 
compatibility problems with external libraries which use off_t in function 
prototypes (I found one such call in php4 source, but it could be that I have 
missed some). I know I will have it enabled in all my PHP builds...

Edin