Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13451 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17679 invoked by uid 1010); 22 Oct 2004 10:59:38 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 15695 invoked from network); 22 Oct 2004 10:59:05 -0000 Received: from unknown (HELO gw2.emini.dk) (192.38.9.232) by pb1.pair.com with SMTP; 22 Oct 2004 10:59:05 -0000 Received: from localhost (localhost [127.0.0.1]) by gw2.emini.dk (Postfix) with ESMTP id BBC0C4867E; Fri, 22 Oct 2004 12:59:04 +0200 (CEST) Organization: Emini ApS To: internals@lists.php.net Date: Fri, 22 Oct 2004 12:59:04 +0200 User-Agent: KMail/1.6.2 Cc: Joe Orton , wez@php.net References: <20041022062249.GA8983@redhat.com> <4e89b42604102202533086a25d@mail.gmail.com> <20041022100842.GB9395@redhat.com> In-Reply-To: <20041022100842.GB9395@redhat.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <200410221259.04475.edink@emini.dk> Subject: Re: [PHP-DEV] _FILE_OFFSET_BITS=64 considered harmful From: edink@emini.dk (Edin Kadribasic) On Friday 22 October 2004 12:08, Joe Orton wrote: > > > But both approaches are feasible, the important thing is to avoid > > > using -D_FILE_OFFSET_BITS=64, which just breaks so much. As far as I can tell we use off_t only once when calling external libraries. And yes it is in a call to zlib when seeking inside gzipped files. However I consider crashing apache children with signal 25 when doing simple is_file() or fopen() on large files really harmful. Apache flat out refuses to start if you have enabled php error log and that file happen to be 2GB or bigger. > > OK, so we should roll back Edins patch from all branches and wait for > > a safer fix. > > Gets my vote... OK. Reverted. Edin