Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13335 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82364 invoked by uid 1010); 14 Oct 2004 12:25:29 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 80392 invoked from network); 14 Oct 2004 12:24:46 -0000 Received: from unknown (HELO theta.altoona-pa.com) (209.161.72.28) by pb1.pair.com with SMTP; 14 Oct 2004 12:24:46 -0000 Received: from JASONGARBER2 (static-207-68-114-163.alt.east.verizon.net [207.68.114.163]) by theta.altoona-pa.com (Postfix) with ESMTP id 9DE0118C76; Wed, 13 Oct 2004 20:40:36 -0400 (EDT) Date: Wed, 13 Oct 2004 20:40:36 -0400 X-Mailer: The Bat! (v3.0) Professional Reply-To: Jason Garber Organization: IonZoft, Inc. X-Priority: 3 (Normal) Message-ID: <759587789.20041013204036@ionzoft.com> To: Andi Gutmans Cc: "Robert Silva" , internals@lists.php.net In-Reply-To: <5.1.0.14.2.20041012143901.0498cec0@localhost> References: <5.1.0.14.2.20041012143901.0498cec0@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Bug #30230 exception handler not working with objects From: jason@ionzoft.com (Jason Garber) Hello Andi, reset_exception_handler() :) -- Best regards, Jason mailto:jason@ionzoft.com Tuesday, October 12, 2004, 5:40:34 PM, you wrote: AG> I see Marcus has already attempted to fix this even though the bug report AG> is still open. AG> Marcus, what exactly did you do? It seems you allow only NULL to reset AG> exception handler and not empty string. Right? AG> So it seems like you agree with me that "" is ugly but the question is if AG> we're breaking something now. AG> It's probably early enough in the game to do so. AG> Andi AG> At 11:44 PM 10/11/2004 -0700, Robert Silva wrote: >>The problem is that set_exception_handler allows you to reset the handler by >>passing an empty string as argument. It did not check to make sure it was a >>string before checking strlen, therefore when passed an array, it assumed >>the user was resetting the handler. This patch only resets when an empty >>string is passed in (an array will set a new handler). >> >>Bob Silva >> >> >>-- >>PHP Internals - PHP Runtime Development Mailing List >>To unsubscribe, visit: http://www.php.net/unsub.php