Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13329 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76384 invoked by uid 1010); 13 Oct 2004 18:18:16 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 76344 invoked from network); 13 Oct 2004 18:18:15 -0000 Received: from unknown (HELO t0x.net) (195.68.251.133) by pb1.pair.com with SMTP; 13 Oct 2004 18:18:15 -0000 Received: from t0x.net (null@six [10.0.0.106]) by t0x.net (8.13.1/8.13.1/Debian-15) with ESMTP id i9DIIAbV008586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Oct 2004 20:18:11 +0200 Message-ID: <416D73DD.9070401@t0x.net> Date: Wed, 13 Oct 2004 20:28:45 +0200 User-Agent: Googlebot/2.1 (+http://www.googlebot.com/bot.html) X-Accept-Language: fr, en-us, en MIME-Version: 1.0 To: Wez Furlong CC: internals@lists.php.net References: <416C7873.9070602@t0x.net> <20041013014320.47616.qmail@pb1.pair.com> <00b101c4b10a$66cd0cc0$3702a8c0@stouen.esds.com> <019701c4b12c$c356a790$3702a8c0@stouen.esds.com> <4e89b4260410130847412e86d@mail.gmail.com> In-Reply-To: <4e89b4260410130847412e86d@mail.gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] new function stream_socket_create_pair From: six@t0x.net (six) hi, socket type checking removed : http://si.kz/~six/stream_socket_pair.notypecheck.diff Vincent Wez Furlong wrote: >I wouldn't bother checking against known types; let sockpair() handle that. >It is possible that someone might want/need to use some other value >which we haven't thought of, or are even aware of. > >--Wez. > >On Wed, 13 Oct 2004 15:58:46 +0200, Vincent NEGRIER wrote: > > >>Here is an updated version of the patch : >>http://si.kz/~six/stream_socket_pair.diff >> >>It now registers STREAM_AF_* and STREAM_SOCK_* long constants, checks the >>domain and type against known types and passes the array of created streams >>as return value instead of a byref param... and the diff is against today's >>CVS this time :) >> >> > > >