Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13320
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <019701c4b12c$c356a790$3702a8c0@stouen.esds.com>
To: "Wez Furlong" <kingwez@gmail.com>
Cc: <internals@lists.php.net>
References: <416C7873.9070602@t0x.net> <20041013014320.47616.qmail@pb1.pair.com> <00b101c4b10a$66cd0cc0$3702a8c0@stouen.esds.com>
Date: Wed, 13 Oct 2004 15:58:46 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] new function stream_socket_create_pair
From: six@t0x.net ("Vincent NEGRIER")

Here is an updated version of the patch :
http://si.kz/~six/stream_socket_pair.diff

It now registers STREAM_AF_* and STREAM_SOCK_* long constants, checks the
domain and type against known types and passes the array of created streams
as return value instead of a byref param... and the diff is against today's
CVS this time :)

regards,
Vincent

----- Original Message -----
From: "Vincent Negrier" <six@t0x.net>
Newsgroups: php.internals
To: <internals@lists.php.net>
Sent: Wednesday, October 13, 2004 11:52 AM
Subject: Re: [PATCH] new function stream_socket_create_pair


> > > the patch is here :
> http://si.kz/~six/stream_socket_create_pair_patch.tgz
> > >
> > To add to Wez's comments, I'd rather see it return an array of socket
> > streams (or FALSE on failure), rather than return true and tuck the
> streams
> > into a by-ref parameter.
>
> It would look simpler, but on the other hand it would break consistency
with
> the behavior of socket_create_pair() and the sockpair() syscall ...
>
> If the above is not a problem for anyone i can rewrite it to return a
> streams array (or FALSE), without the byref param.
>
> regards,
> Vincent