Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13295 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36085 invoked by uid 1010); 12 Oct 2004 22:34:21 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 35923 invoked from network); 12 Oct 2004 22:34:18 -0000 Received: from unknown (HELO jan.prima.de) (83.97.50.139) by pb1.pair.com with SMTP; 12 Oct 2004 22:34:18 -0000 Received: from BAUMBART (p508EA778.dip.t-dialin.net [::ffff:80.142.167.120]) (IDENT: HydraIRC, AUTH: LOGIN tobi) by jan.prima.de with esmtp; Tue, 12 Oct 2004 22:34:15 +0000 Date: Wed, 13 Oct 2004 00:34:11 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <939286075.20041013003411@marcus-boerger.de> To: Andi Gutmans CC: Robert Silva , internals@lists.php.net In-Reply-To: <5.1.0.14.2.20041012144209.0498a5f0@localhost> References: <5.1.0.14.2.20041012144209.0498a5f0@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Resubmitted for review From: helly@php.net (Marcus Boerger) Hello Andi, Tuesday, October 12, 2004, 11:43:11 PM, you wrote: > We were discussing adding a per class (zend_class_entry *) callback for > constants. It might make sense to allow that and if the callback is NULL > then try the constant's hash in zend_class_entry. > That should solve all cases, right? Andi still the patch is a good extension to the engine API and i think we should add it. Why should every programmer that wants constants add constant handlers just to add some basic constants? I see the handlers only to allow soem special cases, maybe to have array consts or whatever. marcus