Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13291 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 25832 invoked by uid 1010); 12 Oct 2004 21:40:51 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 25800 invoked from network); 12 Oct 2004 21:40:50 -0000 Received: from unknown (HELO mail.zend.com) (80.74.107.235) by pb1.pair.com with SMTP; 12 Oct 2004 21:40:50 -0000 Received: (qmail 31108 invoked from network); 12 Oct 2004 21:40:47 -0000 Received: from localhost (HELO AndiNotebook.zend.com) (127.0.0.1) by localhost with SMTP; 12 Oct 2004 21:40:47 -0000 Message-ID: <5.1.0.14.2.20041012143901.0498cec0@localhost> X-Sender: andi@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Tue, 12 Oct 2004 14:40:34 -0700 To: "Robert Silva" , In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] [PATCH] Bug #30230 exception handler not working with objects From: andi@zend.com (Andi Gutmans) References: I see Marcus has already attempted to fix this even though the bug report is still open. Marcus, what exactly did you do? It seems you allow only NULL to reset exception handler and not empty string. Right? So it seems like you agree with me that "" is ugly but the question is if we're breaking something now. It's probably early enough in the game to do so. Andi At 11:44 PM 10/11/2004 -0700, Robert Silva wrote: >The problem is that set_exception_handler allows you to reset the handler by >passing an empty string as argument. It did not check to make sure it was a >string before checking strlen, therefore when passed an array, it assumed >the user was resetting the handler. This patch only resets when an empty >string is passed in (an array will set a new handler). > >Bob Silva > > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php