Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:13285
Return-Path: <kingwez@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 82497 invoked by uid 1010); 12 Oct 2004 19:31:31 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 82415 invoked from network); 12 Oct 2004 19:31:31 -0000
Received: from unknown (HELO mproxy.gmail.com) (216.239.56.240)
  by pb1.pair.com with SMTP; 12 Oct 2004 19:31:31 -0000
Received: by mproxy.gmail.com with SMTP id w67so85786cwb
        for <internals@lists.php.net>; Tue, 12 Oct 2004 12:31:30 -0700 (PDT)
Received: by 10.11.117.63 with SMTP id p63mr546956cwc;
        Tue, 12 Oct 2004 12:31:30 -0700 (PDT)
Received: by 10.11.117.13 with HTTP; Tue, 12 Oct 2004 12:31:30 -0700 (PDT)
Message-ID: <4e89b42604101212317ee6dd61@mail.gmail.com>
Date: Tue, 12 Oct 2004 20:31:30 +0100
Reply-To: Wez Furlong <kingwez@gmail.com>
To: Greg MacLellan <greg@gregmaclellan.com>
Cc: internals@lists.php.net
In-Reply-To: <416C26A9.8050502@gregmaclellan.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <4166EF12.8090107@gregmaclellan.com>
	 <4e89b426041008132243e0d049@mail.gmail.com>
	 <416C26A9.8050502@gregmaclellan.com>
Subject: Re: [PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject()
From: kingwez@gmail.com (Wez Furlong)

On Tue, 12 Oct 2004 14:47:05 -0400, Greg MacLellan
<greg@gregmaclellan.com> wrote:
> Now uses X509_NAME_print_ex(), using the XN_FLAGS_RFC2253 option.

Looks much better now

> bool openssl_csr_subject(mixed csr, string &out)
> 
> Now, I don't do very much C coding, and I'm pretty new to the zend API..
> One thing I couldn't figure out was why (in php) openssl_csr_subject()
> won't put anything into $out if it's passed an undefined variable (where
> as openssl_csr_export, which is very similar, works).

>         PHP_FE(openssl_csr_export,                      arg2_force_ref)
> +       PHP_FE(openssl_csr_subject,                     NULL)

The answer is here; you need to mark the function entry as requiring the
second arg to be passed by ref by replacing that NULL with arg2_force_ref.

If you can make that change and then either put the diff online, or as
a regular MIME plain text attachment and not inlined, so that it is
easy to get at without it being mangled in the email, I will apply it
to CVS.

Thanks :)

--Wez.