Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13246 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70109 invoked by uid 1010); 8 Oct 2004 20:22:29 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 69885 invoked from network); 8 Oct 2004 20:22:27 -0000 Received: from unknown (HELO mproxy.gmail.com) (216.239.56.242) by pb1.pair.com with SMTP; 8 Oct 2004 20:22:27 -0000 Received: by mproxy.gmail.com with SMTP id w67so22707cwb for ; Fri, 08 Oct 2004 13:22:26 -0700 (PDT) Received: by 10.11.119.24 with SMTP id r24mr183542cwc; Fri, 08 Oct 2004 13:22:26 -0700 (PDT) Received: by 10.11.117.13 with HTTP; Fri, 8 Oct 2004 13:22:26 -0700 (PDT) Message-ID: <4e89b426041008132243e0d049@mail.gmail.com> Date: Fri, 8 Oct 2004 21:22:26 +0100 Reply-To: Wez Furlong To: Greg MacLellan Cc: internals@lists.php.net In-Reply-To: <4166EF12.8090107@gregmaclellan.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <4166EF12.8090107@gregmaclellan.com> Subject: Re: [PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject() From: kingwez@gmail.com (Wez Furlong) Two or three comments: - You leak the dynamically allocated buffer returned by X509_NAME_oneline() - X509_NAME_oneline() man page says that its use is discouraged in favour of smarter functions. Is there a possibility that someone will need that functionality? - if you can solve/answer both of the above, please post a link to the patch Thanks :) --Wez. On Fri, 08 Oct 2004 15:48:34 -0400, Greg MacLellan wrote: > I apologize - it helps when I actually attach the patch.