Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13218 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26163 invoked by uid 1010); 7 Oct 2004 09:22:09 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 26124 invoked from network); 7 Oct 2004 09:22:09 -0000 Received: from unknown (HELO out2.smtp.messagingengine.com) (66.111.4.26) by pb1.pair.com with SMTP; 7 Oct 2004 09:22:09 -0000 Received: from web1.messagingengine.com (web1.internal [10.202.2.210]) by frontend1.messagingengine.com (Postfix) with ESMTP id C6A0AC2F5BF; Thu, 7 Oct 2004 05:22:08 -0400 (EDT) Received: by web1.messagingengine.com (Postfix, from userid 99) id 0E6512E39; Thu, 7 Oct 2004 05:22:09 -0400 (EDT) Content-Disposition: inline Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-Mailer: MIME::Lite 1.5 (F2.73; T1.001; A1.64; B3.05; Q3.03) To: internals@lists.php.net, derick@php.net, iliaa@php.net Date: Thu, 07 Oct 2004 02:22:09 -0700 X-Sasl-Enc: MLR0SfmpT18l39A9cW22nQ 1097140929 Message-ID: <1097140929.24210.205955495@webmail.messagingengine.com> Subject: Shall we remove including config.w32.h and php_config.h from php_scandir.c? From: kameshj@fastmail.fm ("Kamesh Jayachandran") Hi All, In main/php_scandir.c we are conditionally including config.w32.h for windows and php_config.h for others. As we are including the php_scandir.h also I feel including config.w32.h and php_config.h is not necessary(php_scandir.h has already would have included either config.w32.h or php_config.h). With regards Kamesh Jayachandran