Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13127 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12167 invoked by uid 1010); 4 Oct 2004 08:19:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 12142 invoked from network); 4 Oct 2004 08:19:40 -0000 Received: from unknown (HELO out2.smtp.messagingengine.com) (66.111.4.26) by pb1.pair.com with SMTP; 4 Oct 2004 08:19:40 -0000 Received: from web1.messagingengine.com (web1.internal [10.202.2.210]) by frontend1.messagingengine.com (Postfix) with ESMTP id 49CB9C2EB01; Mon, 4 Oct 2004 04:19:40 -0400 (EDT) Received: by web1.messagingengine.com (Postfix, from userid 99) id 81415284B; Mon, 4 Oct 2004 04:19:40 -0400 (EDT) Content-Disposition: inline Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-Mailer: MIME::Lite 1.5 (F2.73; T1.001; A1.64; B3.05; Q3.03) Cc: internals@lists.php.net To: sascha@schumann.cx, helly@php.net, sas@php.net Date: Mon, 04 Oct 2004 01:19:40 -0700 X-Sasl-Enc: WOY1iTU4wdQrswfE2n3rgw 1096877980 Message-ID: <1096877980.820.205694745@webmail.messagingengine.com> Subject: FD_CLOEXEC issue From: kameshj@fastmail.fm ("Kamesh Jayachandran") Hi All, I could see in ps_files_open function of ext/session/mod_files.c having fcntl call. Call looks like the following, fcntl(data->fd, F_SETFD, 1); And this change has happened on 2 years and 5 months back(version 1.73 of mod_files.c). The comment has the following, "Set the close-on-exec flag for fds. Child processes should not inherit the fd." If it is the intension the last argument to fcntl should be FD_CLOEXEC right. I agree that FD_CLOEXEC translates to 1 in Linux. But what about other systems like NetWare where it translates to 32768. Can I modify it to FD_CLOEXEC in stead of 1. With regards Kamesh Jayachandran