Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13096 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39872 invoked by uid 1010); 1 Oct 2004 14:01:18 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 37240 invoked from network); 1 Oct 2004 14:00:58 -0000 Received: from unknown (HELO mail.bpservers.com.ar) (200.32.3.79) by pb1.pair.com with SMTP; 1 Oct 2004 14:00:58 -0000 Received: (qmail 12997 invoked by uid 0); 1 Oct 2004 14:00:56 -0000 Received: from unknown (HELO ?192.168.0.240?) (168.226.115.38) by 200-32-3-79.prima.net.ar with SMTP; 1 Oct 2004 14:00:56 -0000 Reply-To: lpedretti@suserver.com Organization: Axon Sistemas To: internals@lists.php.net Date: Fri, 1 Oct 2004 11:02:27 -0300 User-Agent: KMail/1.7 References: <200409301548.40332.lpedretti@suserver.com> <20040930201209.GA3057@romulus.a-s-i.com> In-Reply-To: <20040930201209.GA3057@romulus.a-s-i.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-ID: <200410011102.27458.lpedretti@suserver.com> Subject: Re: [PHP-DEV] [PATCH]Add SO_ORIGINAL_DST support and SOL_IP constant to socket_get_options() From: lpedretti@suserver.com (Leonardo Pedretti) Help needed on this details bob is commenting about the patch (i don't have= =20 much experience on the configure scripts). It would be interesting that someone reports the existence/equivalence of t= he=20 SO_ORIGINAL_DST option on some other systems. Regards Leo On Thursday 30 September 2004 17:12, you wrote: > > This patch adds some quite useful functionalities to socket_get_options= () > > function. > > ... > > Things NOT tested: I don't have solaris, bsd, etc. to test it. If someo= ne > > can test it and report necessary changes, or errors so I can make the > > changes, It will be appreciated. > > At minimum, I would imagine that > > a) changing the autoconf script so that it properly detects if the > underlying operating system has support for the capability in questi= on > is required; > > b) adding #ifdef/#endif pairs based on the autoconf rewrite to include > the proper files on a per-architecture basis. > > If you only have Linux, then doing (a) and (b) for the Linux-specific > case would get your patch a lot farther. If this patch is applied > as-is to the PHP sources and then compiled on anything except linux, > it will break because of #include (at minimum). > > Not that I'm authoritative about PHP adoption; but having submitted > patches before to a variety of projects I've found you're likely > to get farther if you create your patch so that it doesn't break > anyone else's system. > > -Bob =2D-=20 Leonardo Pedretti Axon Sistemas L=EDder de Equipo Proyecto Basalto