Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130785
Feedback-ID: i8414410d:Fastmail
Precedence: list
MIME-Version: 1.0
Date: Wed, 06 May 2026 11:19:35 -0500
To: "php internals" <internals@lists.php.net>
Message-ID: <a04fd5b1-27b8-4b85-93df-05dc55e30499@app.fastmail.com>
In-Reply-To: <CAB1DDB3-8EBD-4205-A5B3-F0D4495B2160@chilliet.eu>
References: <a087d9fa-112a-4631-9c84-3efae641e0db@app.fastmail.com>
 <4985896b-c80a-4302-912e-9f572a260fb5@app.fastmail.com>
 <cf6ac562-7e6f-4eca-a514-6aa3c9692461@app.fastmail.com>
 <a748c98a-180a-475f-93a7-b802c21138e2@app.fastmail.com>
 <88716CA9-38E4-45CA-9471-2D8928CF4DE2@rwec.co.uk>
 <3b2b863d-d179-40c9-ad26-8605e854a331@app.fastmail.com>
 <CAB1DDB3-8EBD-4205-A5B3-F0D4495B2160@chilliet.eu>
Subject: Re: [PHP-DEV] [RFC] Context Managers
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, May 6, 2026, at 8:31 AM, C=C3=B4me Chilliet wrote:
> Le 22 avril 2026 20:28:15 GMT+02:00, Larry Garfield=20
> <larry@garfieldtech.com> a =C3=A9crit=C2=A0:
>>I will stop here, however, and ask for input from the audience.  (Not =
just the regulars in this thread of late, but all of you reading this.) =
 Including if you have an alternate approach to the three listed above t=
hat would have notably fewer cons.
>>
>>--Larry Garfield
>
> I prefer the void return and throw if needed approach, it looks way=20
> more understandable. I was confused by that part when reading the RFC=20
> and really surprised that returning an Throwable on success is ignored=
,=20
> which is not clear at all when reading the interface.

By which you mean the "if you do nothing, the exception is swallowed" ap=
proach?  (IE, more work in the common case.)

My reluctance there is that it will become really easy to forget to prop=
agate.

public function exitContext(?Throwable $e) {
  fclose($this->fp);
}

That seems like it should be all you need, but it will also silently swa=
llow any errors, so whatever code uses this context manager won't know i=
f it was successful or not.  That seems not-great to me.

> The in-out parameter works too but is a bit weirder, and makes it=20
> unclear what happens if exitContext throws.
>
> It's also unclear to me in the current desugarized version what happen=
s=20
> when exitContext throws, the reset of the context var does not happen =
?=20
> There is nothing to handle that.
>
> Co=CC=82me

We'll have to clean up the desugared versions once we decide what they s=
hould actually be. :-)  There's probably a bug in there at the moment.

--Larry Garfield