Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130696
Precedence: list
MIME-Version: 1.0
References: <CAEKnhAFZXqWH20Cy2g6-0c2V1Vd4w-N0M4xefzt6tTEp90+LqQ@mail.gmail.com>
 <CAEKnhAF2bqkNcHnXGa66JhGBsQRD3KE1tBarXzPJ9jf_7Od0Bw@mail.gmail.com>
 <CAPyeZ4Ou5XMyAqGRP_MYHGb3hLyu5F508tE7cVEsHMA5VbSH6A@mail.gmail.com>
 <CAEKnhAFqcskpHr-JDDk6rjFX7qQgWnP73EgKRcm4pYqdXPbuiA@mail.gmail.com> <126fb4b28fde5cb46753d22edd17ab01@bastelstu.be>
In-Reply-To: <126fb4b28fde5cb46753d22edd17ab01@bastelstu.be>
Date: Sun, 26 Apr 2026 00:04:33 +0200
Message-ID: <CAEKnhAFp9f8QZZ3n_aM0fkTeLVBS48h31XKshXi3u8D0nxk2qw@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] Polling API
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Valentin Udaltsov <udaltsov.valentin@gmail.com>, 
	PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b571300650501100"
From: bukka@php.net (Jakub Zelenka)

--000000000000b571300650501100
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 2, 2026 at 10:15=E2=80=AFPM Tim D=C3=BCsterhus <tim@bastelstu.b=
e> wrote:

> Hi
>
> Am 2026-03-31 15:23, schrieb Jakub Zelenka:
> > There is actually no internal API for hooks so it would require using
> > object handlers (which is from the user space point of view just
> > __get). It
> > means no stubs declaration either. We also don't have an internal
> > policy
> > where to use hooks and where methods. So there are still lots of
> > blockers
> > to start using it in core.
>
> While I agree with the conclusion that using hooks internally is
> complicated and there is no real policy there, Valentin was actually
> making a good point: We could use regular `readonly` properties for
> those cases where we're just exposing a =E2=80=9Cconstructor parameter=E2=
=80=9D.
> Specifically:
>
> - Context::getBackend() -> public readonly Backend $backend;
> - Watcher::getHandle() -> public readonly Handle $handle;
>
> Potentially Watcher::$data could also be a regular (non-readonly)
> property, or does `modifyData()` contain additional logic that is not
> just =E2=80=9Cstore the value somewhere=E2=80=9D?
>

I tried to convert few but it resulted in quite ugly inconsistent mess.
Some of those need back calls to backend so they are really not ideal for
this. So I will stick with the current getters as the API is a bit nicer
with them IMO.

Kind regards,

Jakub

--000000000000b571300650501100
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, Apr 2, 2026 at 10:15=E2=80=AFPM T=
im D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be<=
/a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_container"><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex">Hi<br>
<br>
Am 2026-03-31 15:23, schrieb Jakub Zelenka:<br>
&gt; There is actually no internal API for hooks so it would require using<=
br>
&gt; object handlers (which is from the user space point of view just <br>
&gt; __get). It<br>
&gt; means no stubs declaration either. We also don&#39;t have an internal =
<br>
&gt; policy<br>
&gt; where to use hooks and where methods. So there are still lots of <br>
&gt; blockers<br>
&gt; to start using it in core.<br>
<br>
While I agree with the conclusion that using hooks internally is <br>
complicated and there is no real policy there, Valentin was actually <br>
making a good point: We could use regular `readonly` properties for <br>
those cases where we&#39;re just exposing a =E2=80=9Cconstructor parameter=
=E2=80=9D. <br>
Specifically:<br>
<br>
- Context::getBackend() -&gt; public readonly Backend $backend;<br>
- Watcher::getHandle() -&gt; public readonly Handle $handle;<br>
<br>
Potentially Watcher::$data could also be a regular (non-readonly) <br>
property, or does `modifyData()` contain additional logic that is not <br>
just =E2=80=9Cstore the value somewhere=E2=80=9D?<br></blockquote><div><br>=
</div><div>I tried to convert few but it resulted in quite ugly inconsisten=
t mess. Some of those need back calls to backend so they are really not ide=
al for this. So I will stick with the current getters as the API is a bit n=
icer with them IMO.</div><div><br></div><div>Kind regards,</div><div><br></=
div><div>Jakub</div></div></div>

--000000000000b571300650501100--