Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130657
Precedence: list
MIME-Version: 1.0
References: <CALaXqqRuboaxOnt+VEkGc1kte8bfNca1wPUwmtsdtetnh_4GAA@mail.gmail.com>
 <b5cf3c4c-4562-73a2-ddd6-a84fc8c25f6c@php.net>
In-Reply-To: <b5cf3c4c-4562-73a2-ddd6-a84fc8c25f6c@php.net>
Date: Wed, 15 Apr 2026 19:11:20 -0700
Message-ID: <CALaXqqQHa0bm5FhJTwjHV_Ex2duLbBX4saKM+PqAAc1bxTTdvg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] `#[\Override]` for class constants
To: Derick Rethans <derick@php.net>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004b6fad064f8a5b10"
From: daniel.e.scherzer@gmail.com (Daniel Scherzer)

--0000000000004b6fad064f8a5b10
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 31, 2026 at 2:56=E2=80=AFAM Derick Rethans <derick@php.net> wro=
te:

>
> I think I'm on the " Always reject using #[\Override] on an enum case,
> saying that the attribute does not target enum cases" side here, as
> mixing class constants with enum cases sounds like a mismatch to me.
>
> cheers,
> Derick
>

On the other hand, if someone is intentionally overriding an interface
constant with an enum case, all the more reason that the overriding should
be explicitly documented, which is what `#[\Override]` would do.

-Daniel

--0000000000004b6fad064f8a5b10
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Mar 31, 2026 at 2:56=E2=80=AFAM D=
erick Rethans &lt;<a href=3D"mailto:derick@php.net">derick@php.net</a>&gt; =
wrote:</div><div class=3D"gmail_quote gmail_quote_container"><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex"><br>
I think I&#39;m on the &quot; Always reject using #[\Override] on an enum c=
ase, <br>
saying that the attribute does not target enum cases&quot; side here, as <b=
r>
mixing class constants with enum cases sounds like a mismatch to me.<br>
<br>
cheers,<br>
Derick<br></blockquote><div><br></div><div>On the other hand, if someone is=
 intentionally overriding an interface constant with an enum case, all the =
more reason that the overriding should be explicitly documented, which is w=
hat `#[\Override]` would do.</div><div><br></div><div>-Daniel</div><div></d=
iv><div>=C2=A0</div></div></div>

--0000000000004b6fad064f8a5b10--