Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130651
Precedence: list
MIME-Version: 1.0
Date: Wed, 15 Apr 2026 22:21:20 +0200
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Followup Improvements for ext/uri
In-Reply-To: <e402a7f8-714d-45cb-bf93-f3536667b4c5@app.fastmail.com>
References: <CAH5C8xXUPKgd0wWwLC3G2Ye=kRZN58gK3DY82v5GoduBNNtb5A@mail.gmail.com>
 <83238ad3-c844-4457-dfb3-11321787e022@php.net>
 <CAH5C8xUOEkfQ6u8AxuV8UGjWU0h7goDsvWa9QQmANhNdU=Dwhw@mail.gmail.com>
 <CAOV5rgZ1LTVf9PBpfQekahmESo=KXE=RVrpeUXrbqxG4OSDMnQ@mail.gmail.com>
 <d6a46bb627a9545e621f37e83c0441e5@glaive.pro>
 <CAOV5rgZGKJEo+jV7q-qQFB59CXhfNwadYPDbm70e_F+1v=Fgng@mail.gmail.com>
 <CAH5C8xWwcNC3z=FxQZiN2r1aZ1FgriVNAtdw+YwhaN4S2joyzw@mail.gmail.com>
 <CAOV5rgaLX9s-=WZZgxoTE4wmWEzL9mZUF-d8bzGrN3BQDU7i3w@mail.gmail.com>
 <CAOV5rgY3+PrOk2sH0iZ2ne1wg1WVzW4evh6qwu1nyq68tMH-9A@mail.gmail.com>
 <CAH5C8xUEBtywOxgV4zgHVhdzO0KoFejtp04q0LQ+bEAb9nUAvw@mail.gmail.com>
 <CAOV5rgaGjJ+_Qa10pVaCYD_aozV10+UHvLUuVuNOXTz87xHpXA@mail.gmail.com>
 <CAOV5rgZ5y6YF3hLeDAc8TcaOyxkbbF7S0U7R7JMx8Cwff=3QGA@mail.gmail.com>
 <CAH5C8xXAtUN0ja_thZqbN4u4nndr2Lp_SxqZT3E+WN5ASFqWSA@mail.gmail.com>
 <CAH5C8xVjx1v_CX+5O4sj7CVyJOx4rDASvuqOukWfgupPa=YtGA@mail.gmail.com>
 <CAOV5rgbsDscEffqiv+c7WThN-Aj0xhL0w5eE13ALY_F5Kmcwmg@mail.gmail.com>
 <CAH5C8xXXrY5iPuAcL0XXYDoRPh=Tz0m7xhszspNqXnfVmM_aAQ@mail.gmail.com>
 <CAH5C8xVdz8N5J+poc7px5PfU0OC+bDebJWrVdYB30O2z2OB+Fw@mail.gmail.com>
 <e402a7f8-714d-45cb-bf93-f3536667b4c5@app.fastmail.com>
Message-ID: <4643495923b044673383e38c68beca73@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2026-04-15 22:04, schrieb Larry Garfield:
> For host type detection, what does a null return signify?  UrlHostType 
> includes an Empty case, which I'd assume would be used in that 
> situation.  And I'd rather have an Empty case on UriHostType as well 
> rather than null, unless someone can make a good argument for using 
> null instead...

An empty host is semantically different from a missing host.

You can check that with the existing functionality in PHP 8.5, where 
`getHost()` is `?string` for both RFC 3986 and WHATWG URL in accordance 
with the respective standards. If `getHostType()` will return `null` if 
`getHost()` returns `null`. The cases of the Ur[il]HostType enums in the 
featured RFC are also pulled straight from the respective 
specifications.

> LeadingSlashPolicy::AddForNonEmtpyRelative is... a mouthful.  
> Self-documenting is fine, but as the example demonstrates it quickly 
> creates super long lines.  That could be a problem in, say, a match() 
> statement, inside a method, where with that enum value as a case you'd 
> be more than halfway across the screen before you get to the executable 
> code for that case.  Is there no way to make that whole thing shorter?

FYI: I've also had little time for this RFC, but I've started discussing 
spinning off the “path segment” part of the RFC into a dedicated RFC 
with Mate off-list a few days ago, similarly to how the query parameters 
part has been spun off because it has become too complicated for a bulk 
RFC.

> I'm not sure how I feel about object methods on the enum.  That would 
> be something like:
> 
> use Uri\Rfc3986\PercentEncoder;
> 
> PercentEncoder::Path->encode($someval);
> 
> Right? […]

Yes.

> use Uri\Rfc3986\encode;
> 
> encode($someval, PercentEncoder::Path);
> 
> Is about the same length, and with PFA easily pre-configurable, and 
> closer to what is typically seen in the wild today.

FWIW: The enum would also be “pre-configurable” with 
https://wiki.php.net/rfc/partial_function_application_this. Arnaud and I 
are working on a more general version of that RFC based on Bob's 
feedback, but will need to figure out the latest edge cases before 
proposing it.

Best regards
Tim Düsterhus