Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130649
Feedback-ID: i8414410d:Fastmail
Precedence: list
MIME-Version: 1.0
Date: Wed, 15 Apr 2026 15:04:23 -0500
To: "php internals" <internals@lists.php.net>
Message-ID: <e402a7f8-714d-45cb-bf93-f3536667b4c5@app.fastmail.com>
In-Reply-To: 
 <CAH5C8xVdz8N5J+poc7px5PfU0OC+bDebJWrVdYB30O2z2OB+Fw@mail.gmail.com>
References: 
 <CAH5C8xXUPKgd0wWwLC3G2Ye=kRZN58gK3DY82v5GoduBNNtb5A@mail.gmail.com>
 <83238ad3-c844-4457-dfb3-11321787e022@php.net>
 <CAH5C8xUOEkfQ6u8AxuV8UGjWU0h7goDsvWa9QQmANhNdU=Dwhw@mail.gmail.com>
 <CAOV5rgZ1LTVf9PBpfQekahmESo=KXE=RVrpeUXrbqxG4OSDMnQ@mail.gmail.com>
 <d6a46bb627a9545e621f37e83c0441e5@glaive.pro>
 <CAOV5rgZGKJEo+jV7q-qQFB59CXhfNwadYPDbm70e_F+1v=Fgng@mail.gmail.com>
 <CAH5C8xWwcNC3z=FxQZiN2r1aZ1FgriVNAtdw+YwhaN4S2joyzw@mail.gmail.com>
 <CAOV5rgaLX9s-=WZZgxoTE4wmWEzL9mZUF-d8bzGrN3BQDU7i3w@mail.gmail.com>
 <CAOV5rgY3+PrOk2sH0iZ2ne1wg1WVzW4evh6qwu1nyq68tMH-9A@mail.gmail.com>
 <CAH5C8xUEBtywOxgV4zgHVhdzO0KoFejtp04q0LQ+bEAb9nUAvw@mail.gmail.com>
 <CAOV5rgaGjJ+_Qa10pVaCYD_aozV10+UHvLUuVuNOXTz87xHpXA@mail.gmail.com>
 <CAOV5rgZ5y6YF3hLeDAc8TcaOyxkbbF7S0U7R7JMx8Cwff=3QGA@mail.gmail.com>
 <CAH5C8xXAtUN0ja_thZqbN4u4nndr2Lp_SxqZT3E+WN5ASFqWSA@mail.gmail.com>
 <CAH5C8xVjx1v_CX+5O4sj7CVyJOx4rDASvuqOukWfgupPa=YtGA@mail.gmail.com>
 <CAOV5rgbsDscEffqiv+c7WThN-Aj0xhL0w5eE13ALY_F5Kmcwmg@mail.gmail.com>
 <CAH5C8xXXrY5iPuAcL0XXYDoRPh=Tz0m7xhszspNqXnfVmM_aAQ@mail.gmail.com>
 <CAH5C8xVdz8N5J+poc7px5PfU0OC+bDebJWrVdYB30O2z2OB+Fw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Followup Improvements for ext/uri
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Mar 30, 2026, at 3:40 PM, M=C3=A1t=C3=A9 Kocsis wrote:
> Hi Ignace, Everyone,
>
> I have recently clarified/updated a few things in the RFC:
>
> - How Uri\Rfc3986\Uri::getDecodedPathSegments() and=20
> Uri\WhatWg\Url::getDecodedPathSegments() exactly work
> - The exact list of percent-encoding modes and their behavior
> - Exactly how the percentDecode() methods work
>
> Please have a look at these changes, because I'd like to bring this RF=
C=20
> to a vote soonish, since there's not too much debate
> going on for a while.
>
> Regards,
> M=C3=A1t=C3=A9

My apologies for taking so long to review this.  It's been a hectic few =
weeks Chez Crell. :-)

From the builder examples:
"echo $url->toAsciiString; "

Is that missing () ?

I'm not sure I agree that one should always reset() a builder before usi=
ng it.  There's plenty of good reasons to make a builder part way, then =
fill the rest in separately.  But I do agree that reset() should exist, =
so the non-normative advice there is not a blocker for me.

For host type detection, what does a null return signify?  UrlHostType i=
ncludes an Empty case, which I'd assume would be used in that situation.=
  And I'd rather have an Empty case on UriHostType as well rather than n=
ull, unless someone can make a good argument for using null instead...

LeadingSlashPolicy::AddForNonEmtpyRelative is... a mouthful.  Self-docum=
enting is fine, but as the example demonstrates it quickly creates super=
 long lines.  That could be a problem in, say, a match() statement, insi=
de a method, where with that enum value as a case you'd be more than hal=
fway across the screen before you get to the executable code for that ca=
se.  Is there no way to make that whole thing shorter?

I will also agree with Tim's comments in a separate message: The encode/=
decode operations should not be static methods.  They do not relate to t=
he *type*/*class*, therefore they should not be on the type/class.  Func=
tions in namespaces are totally fine.

I'm not sure how I feel about object methods on the enum.  That would be=
 something like:

use Uri\Rfc3986\PercentEncoder;

PercentEncoder::Path->encode($someval);

Right?  That.. could work, but also feels quite convoluted. =20

use Uri\Rfc3986\encode;

encode($someval, PercentEncoder::Path);

Is about the same length, and with PFA easily pre-configurable, and clos=
er to what is typically seen in the wild today.  I think I'd lean toward=
 "just a function", but I wouldn't vote against the enum method approach=
 just for that.

Aside from those (overall minor) points, this all looks great, and I app=
reciate how much research has clearly gone into it!

--Larry Garfield