Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130604
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Precedence: list
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.500.181\))
Subject: Re: [PHP-DEV] DocComments for internal functions
Date: Fri, 10 Apr 2026 23:47:15 +0200
References: <CF327F5E-E105-4405-AB05-EE4BAFFCCB56@cschneid.com>
 <2FGg02j2pKAcV7nu_mLBtetGMhhax9Ernyly_rH2jDaWzNUSlWMk7pYf4mEq9QIbuBj4tgxA9xLlTEnwPVqmxSTw558yTPNrEsk53G63xtQ=@gpb.moe>
 <30448463-1ABD-4005-89CC-3F558C7FE9B2@cschneid.com>
 <FAA5044A-D145-4972-B45A-0D4B6DCEBA6D@php.net>
To: internals@lists.php.net
In-Reply-To: <FAA5044A-D145-4972-B45A-0D4B6DCEBA6D@php.net>
Message-ID: <C522ACBB-9591-405C-B8F7-00C347E29A75@cschneid.com>
From: cschneid@cschneid.com (Christian Schneider)

Am 10.04.2026 um 17:40 schrieb Derick Rethans <derick@php.net>:
> On 10 April 2026 15:21:34 BST, Christian Schneider =
<cschneid@cschneid.com> wrote:
>> Am 10.04.2026 um 12:54 schrieb Gina P. Banyard <internals@gpb.moe>:
>>> On Thursday, 9 April 2026 at 14:33, Christian Schneider =
<cschneid@cschneid.com> wrote:
>>>> The implementation can be examined at
>>>> =
https://github.com/php/php-src/compare/master...chschneider:php-src:intern=
al-functions-doccomments
>>>=20
>>> I am not *fully* convinced that we should add DocComments for =
internal parameters/functions/classes/constants, as this feels like a =
lot of complexity.
>>=20
>> What kind of complexity are you thinking about? Code-wise? =
Integration into the build process?
>=20
> I'm wondering how much this does to increase the size of the PHP =
compiled binaries.

On my machine it adds about 2M (7%) as the sapi/cli/php binary increases =
from ~28M to ~30M for a build with default ./configure and
	CFLAGS=3D"-O3 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64"

I would assume this is mostly in a read-only data section and hence =
shareable between processes.

- Chris