Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130592
Content-Type: text/plain;
	charset=utf-8
Precedence: list
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.500.181\))
Subject: Re: [PHP-DEV] [RFC] Display Function Arguments in Errors
In-Reply-To: <CAJp_myVk77UmHP2d-VFsdFsRwSJUG+rsdQhPjPz_F848TO3EeA@mail.gmail.com>
Date: Wed, 8 Apr 2026 19:08:44 -0300
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <B83E722E-D3E3-4FB4-97E1-CE115BACF977@cmpct.info>
References: <939CFA28-A6FF-433F-85A0-B83345CEF4A6@cmpct.info>
 <CAJp_myVk77UmHP2d-VFsdFsRwSJUG+rsdQhPjPz_F848TO3EeA@mail.gmail.com>
To: Matthew Weier O'Phinney <mweierophinney@gmail.com>
From: calvin@cmpct.info (Calvin Buckley)

On Apr 2, 2026, at 11:25=E2=80=AFAM, Matthew Weier O'Phinney =
<mweierophinney@gmail.com> wrote:
>=20
> On Wed, Mar 11, 2026 at 10:56=E2=80=AFAM Calvin Buckley =
<calvin@cmpct.info> wrote:
> Based on the feedback I had from my proposal for function arguments in
> errors last week, I'd like to introduce an RFC for it. Please let me
> know what you think and please raise any possible issues.
>=20
> https://wiki.php.net/rfc/display_error_function_args
>=20
> Have you done any benchmarking on this? What is the performance impact =
when it is enabled versus disabled? That information will be useful if =
this passes so that users can understand not just the security impact of =
having this information reported in logs, but the performance impact.
>=20
> --=20
> Matthew Weier O'Phinney
> mweierophinney@gmail.com
> https://mwop.net/
> he/him

I've been doing a very stupid benchmark (let's call it Lhogstones):

<?php

/* -d error_include_args=3DX -d display_errors=3D0 -d =
error_log=3D/tmp/test */

$iter =3D isset($argv[1]) ? intval($argv[1]) : 10000;
$start =3D hrtime(true);
for ($i =3D 0; $i < $iter; $i++) {
        hex2bin("ABC"); /* or like unlink("/") for something that does =
more */
}
$end =3D hrtime(true);
$total_ns =3D $end - $start;
$total =3D $total_ns / 1_000_000_000;

echo "Finished $iter iterations in $total sec\n";

?>

On an M1 Pro:

Iterations  With         Without
10000       0.025276917  0.016741333
100000      0.189566666  0.123559584
1000000     1.798127917  1.146331917
10000000    18.1332335   11.267384125

There is an impact from turning it on, but my feeling is that it would =
be pretty minor. If your code has a lot of warnings/errors, then my =
feeling is that errors should be fixed before you can or should measure =
performance. Calling php_error_docref in a tight loop isn't really =
normal behaviour. So, while there is an impact, I also don't think it =
matters too much. If people think the impact *does* matter and is =
significant, then I could add a vote to separate the production vs. =
development INI value.=