Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130554
Precedence: list
MIME-Version: 1.0
Date: Fri, 03 Apr 2026 20:33:14 +0300
To: Ilia <ilia@ilia.ws>
Cc: PHP Developers Mailing List <internals@lists.php.net>
Subject: Re: [PHP-DEV] PDO SQLite: statement attributes for SQL text retrieval
In-Reply-To: <CALkpNnS0_9T421vjBoYxuqYKZoSWUMuOp7vGKCtQbZpSp17ivw@mail.gmail.com>
References: <CALkpNnS0_9T421vjBoYxuqYKZoSWUMuOp7vGKCtQbZpSp17ivw@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.8
Message-ID: <4d8d56c4522430326d796e240b24cdd2@glaive.pro>
Organization: SIA "Glaive.pro"
Content-Type: multipart/alternative;
 boundary="=_0cb922866a7204a8946220225b74b3ea"
From: juris@glaive.pro (Juris Evertovskis)

--=_0cb922866a7204a8946220225b74b3ea
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2026-04-03 15:29, Ilia wrote:

> Hi internals,
> 
> I'm looking for feedback on a small pdo_sqlite addition.
> 
> PR: https://github.com/php/php-src/pull/21456
> Implements: https://github.com/php/php-src/issues/21322
> 
> Two new read-only statement attributes on Pdo\Sqlite:
> - Pdo\Sqlite::ATTR_SQL -- original SQL text of a prepared statement 
> (via sqlite3_sql())
> - Pdo\Sqlite::ATTR_EXPANDED_SQL -- SQL with bound parameters inlined 
> (via sqlite3_expanded_sql())
> 
> $stmt = $db->prepare('SELECT :name AS greeting');
> $stmt->bindValue(':name', 'hello');
> $stmt->execute();
> 
> $stmt->getAttribute(Pdo\Sqlite::ATTR_SQL);          // "SELECT :name AS 
> greeting"
> $stmt->getAttribute(Pdo\Sqlite::ATTR_EXPANDED_SQL); // "SELECT 'hello' 
> AS greeting"
> 
> This mirrors SQLite3Stmt::getSQL() from the non-PDO API, but uses PDO's 
> getAttribute() mechanism rather than adding a driver-specific method. 
> The attribute system is how PDO drivers expose driver-specific 
> functionality, so it's a natural fit.
> 
> ATTR_EXPANDED_SQL is gated behind a configure check for 
> sqlite3_expanded_sql availability.
> 
> I don't think this needs a full RFC given the scope (two read-only 
> attributes, single driver, no BC impact), but I wanted input from the 
> list.
> 
> Thoughts?
> 
> --
> 
> Ilia Alshanetsky
> Technologist, CTO, Entrepreneur
> E: ilia@ilia.ws
> T: @iliaa
> B: http://ilia.ws

Hello,

I don't doubt the need to extract statement strings since logging the 
executed statements is something I do often, especially during 
development (tools like laravel-debugbar and newrelic's achieve that). 
It helps noticing repeated queries and other issues.

But two things here are unclear to me:
- What's insufficient with `->queryString` and other existing features? 
Does one of these overlap with `->queryString` or not?
- What's so special about SQLite? Wouldn't the same need be just as 
present for any other driver?

BR,
Juris
--=_0cb922866a7204a8946220225b74b3ea
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset=
=3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen=
eva,sans-serif'>
<p id=3D"reply-intro">On 2026-04-03 15:29, Ilia wrote:</p>
<blockquote type=3D"cite" style=3D"padding: 0 0.4em; border-left: #1010ff 2=
px solid; margin: 0">
<div id=3D"replybody1">
<div dir=3D"ltr">
<div>Hi internals,<br /><br />I'm looking for feedback on a small pdo_sqlit=
e addition.<br /><br />PR: <a href=3D"https://github.com/php/php-src/pull/2=
1456" target=3D"_blank" rel=3D"noopener noreferrer">https://github.com/php/=
php-src/pull/21456</a><br />Implements: <a href=3D"https://github.com/php/p=
hp-src/issues/21322" target=3D"_blank" rel=3D"noopener noreferrer">https://=
github.com/php/php-src/issues/21322</a><br /><br />Two new read-only statem=
ent attributes on Pdo\Sqlite:<br />- Pdo\Sqlite::ATTR_SQL &mdash; original =
SQL text of a prepared statement (via sqlite3_sql())<br />- Pdo\Sqlite::ATT=
R_EXPANDED_SQL &mdash; SQL with bound parameters inlined (via sqlite3_expan=
ded_sql())<br /><br />$stmt =3D $db-&gt;prepare('SELECT :name AS greeting')=
;<br />$stmt-&gt;bindValue(':name', 'hello');<br />$stmt-&gt;execute();<br =
/><br />$stmt-&gt;getAttribute(Pdo\Sqlite::ATTR_SQL); &nbsp; &nbsp; &nbsp; =
&nbsp; &nbsp;// "SELECT :name AS greeting"<br />$stmt-&gt;getAttribute(Pdo\=
Sqlite::ATTR_EXPANDED_SQL); // "SELECT 'hello' AS greeting"<br /><br />This=
 mirrors SQLite3Stmt::getSQL() from the non-PDO API, but uses PDO's getAttr=
ibute() mechanism rather than adding a driver-specific method. The attribut=
e system is how PDO drivers expose driver-specific functionality, so it's a=
 natural fit.<br /><br />ATTR_EXPANDED_SQL is gated behind a configure chec=
k for sqlite3_expanded_sql availability.<br /><br />I don't think this need=
s a full RFC given the scope (two read-only attributes, single driver, no B=
C impact), but I wanted input from the list.<br /><br />Thoughts?<br /><br =
/></div>
<span class=3D"v1gmail_signature_prefix">-- </span><br />
<div class=3D"v1gmail_signature" dir=3D"ltr">
<div dir=3D"ltr">Ilia Alshanetsky
<div>Technologist, CTO, Entrepreneur</div>
<div>E: <a href=3D"mailto:ilia@ilia.ws" rel=3D"noreferrer">ilia@ilia.ws</a>=
</div>
<div>T: @iliaa&nbsp;</div>
<div>B: <a href=3D"http://ilia.ws" target=3D"_blank" rel=3D"noopener norefe=
rrer">http://ilia.ws</a></div>
</div>
</div>
</div>
</div>
</blockquote>
<p>Hello,</p>
<p>I don't doubt the need to extract statement strings since logging the ex=
ecuted statements is something I do often, especially during development (t=
ools like laravel-debugbar and newrelic's achieve that). It helps noticing =
repeated queries and other issues.</p>
<p>But two things here are unclear to me:<br />- What's insufficient with `=
-&gt;queryString` and other existing features? Does one of these overlap wi=
th `-&gt;queryString` or not?<br />-&nbsp;What's so special about SQLite? W=
ouldn't the same need be just as present for any other driver?</p>
<p>BR,<br />Juris</p>

</body></html>

--=_0cb922866a7204a8946220225b74b3ea--