Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130534
Precedence: list
MIME-Version: 1.0
References: <CAEKnhAEO8w0GJXTVyH_nwK8nGQGdJcNNkGOPMnYDVrcsNGrm4A@mail.gmail.com>
 <CAEKnhAGCxHOTOmtU7c8rqm3MY8a4vvoJ3NH7BdR0SNp+7sFWHg@mail.gmail.com>
 <CAOWwgpk5wpyWo-qeVO4mGwKygTMFMeXDt3_1Cf4wLOK4ZgZaSw@mail.gmail.com>
 <CAEKnhAHFKYbXMm7LU+-yexLgwRmw=fPx8b5vUVNOQUg5AjRbaw@mail.gmail.com>
 <f49931e8334d6c745d5daa5afd4ebcd8@bastelstu.be> <CAEKnhAGPUowhK8z1MKGqkU3otk0oi0pqMu4=UO_V3JGQK9LscQ@mail.gmail.com>
 <1597c99a0ad7dc1e55a40f952d7536c5@bastelstu.be>
In-Reply-To: <1597c99a0ad7dc1e55a40f952d7536c5@bastelstu.be>
Date: Thu, 2 Apr 2026 19:25:11 +0200
Message-ID: <CAEKnhAGANDMwhTM3TK4O242aL2FGCQFqTNTHaOeb-S2ZfCnm7Q@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] Stream Error Handling Improvements
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Nicolas Grekas <nicolas.grekas+php@gmail.com>, 
	PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004d65ca064e7d7c1d"
From: bukka@php.net (Jakub Zelenka)

--0000000000004d65ca064e7d7c1d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

On Tue, Mar 31, 2026 at 11:59=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.=
be> wrote:

>
> 1. "// Search for specific codes using array_any (PHP 8.5+)"
>
> array_any is already available in PHP 8.4. The same is true for
> "array_find (PHP 8.5+)" in the same example. But given it's an RFC for
> PHP 8.6 anyways, we already know that these functions exist, so the hint
> could just be removed entirely.
>
>
Fixed


> 2. In the example example "$primary =3D $errors[0] ?? null;"
>
> This can just be `$primary =3D array_first($errors);` (PHP 8.5+). Same fo=
r
> the other examples. The examples should ideally show the cleanest
> possible code :-)
>
>
Fixed


> 3. For "StreamErrorCode::is*()"
>
> Can error codes fall into multiple categories or is it always a single
> one? If it's guaranteed to be a single category, then perhaps a
> `->getErrorCategory()` method returning a StreamErrorCodeCategory enum
> makes more sense and allow for simpler / more efficient code when folks
> are interested in checking for multiple different categories. Instead of
> `$code->isNetworkError() || $code->isFileSystemError()` they can do
> `\in_array($code->getErrorCategory(),
> [StreamErrorCodeCategory::NetworkError,
> StreamErrorCodeCategory::FileSystemError], true)` or use a `match()`
> expression instead.
>
>
After doing a review of the categories, I decided to drop all the helpers
and not expose categories in any way. More on the reasoning in my other
replay to Pierre.

Kind regards,

Jakub

--0000000000004d65ca064e7d7c1d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote gmail_quote_con=
tainer"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Mar 31, 2026 at 11:59=
=E2=80=AFAM Tim D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@=
bastelstu.be</a>&gt; wrote:</div><blockquote class=3D"gmail_quote" style=3D=
"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-le=
ft:1ex">
<br>
1. &quot;// Search for specific codes using array_any (PHP 8.5+)&quot;<br>
<br>
array_any is already available in PHP 8.4. The same is true for <br>
&quot;array_find (PHP 8.5+)&quot; in the same example. But given it&#39;s a=
n RFC for <br>
PHP 8.6 anyways, we already know that these functions exist, so the hint <b=
r>
could just be removed entirely.<br>
<br></blockquote><div><br></div><div>Fixed</div><div>=C2=A0</div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex">
2. In the example example &quot;$primary =3D $errors[0] ?? null;&quot;<br>
<br>
This can just be `$primary =3D array_first($errors);` (PHP 8.5+). Same for =
<br>
the other examples. The examples should ideally show the cleanest <br>
possible code :-)<br>
<br></blockquote><div><br></div><div>Fixed</div><div>=C2=A0</div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex">
3. For &quot;StreamErrorCode::is*()&quot;<br>
<br>
Can error codes fall into multiple categories or is it always a single <br>
one? If it&#39;s guaranteed to be a single category, then perhaps a <br>
`-&gt;getErrorCategory()` method returning a StreamErrorCodeCategory enum <=
br>
makes more sense and allow for simpler / more efficient code when folks <br=
>
are interested in checking for multiple different categories. Instead of <b=
r>
`$code-&gt;isNetworkError() || $code-&gt;isFileSystemError()` they can do <=
br>
`\in_array($code-&gt;getErrorCategory(), <br>
[StreamErrorCodeCategory::NetworkError, <br>
StreamErrorCodeCategory::FileSystemError], true)` or use a `match()` <br>
expression instead.<br>
<br></blockquote><div><br></div><div>After doing a review of the categories=
, I decided to drop all the helpers and not expose categories in any way. M=
ore on the reasoning in my other replay to Pierre.</div><div><br></div><div=
>Kind regards,</div><div><br></div><div>Jakub</div></div></div>

--0000000000004d65ca064e7d7c1d--