Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130518
Precedence: list
MIME-Version: 1.0
References: <CAEKnhAFZXqWH20Cy2g6-0c2V1Vd4w-N0M4xefzt6tTEp90+LqQ@mail.gmail.com>
 <926a26a6-eb89-49aa-a387-6cc79caa29c1@bastelstu.be> <CAEKnhAE91_qMYRTBpdY_FETV4J_SjonAvK0LqnfyAA81nQEftA@mail.gmail.com>
 <b9791d4632ebaa247fe8c4e541ee642a@bastelstu.be> <CAEKnhAEDCGbM6RpqpAT=f_tP4Z239z7_Xbe8_0ZimC3FeziF1A@mail.gmail.com>
 <d76f56bb16e880292d23f4ecc34f65fb@bastelstu.be>
In-Reply-To: <d76f56bb16e880292d23f4ecc34f65fb@bastelstu.be>
Date: Tue, 31 Mar 2026 15:24:44 +0200
Message-ID: <CAEKnhAHucoij+V-6nxCtSr+qttkEeCtaY16txuY3rA1vc_3+Tg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Polling API
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b4b611064e51e4fe"
From: bukka@php.net (Jakub Zelenka)

--000000000000b4b611064e51e4fe
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Mar 31, 2026 at 11:23=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.=
be> wrote:

> Hi
>
> Sorry for the late feedback, it's hard juggling all the different RFCs
> that are in progress to provide meaningful feedback.
>
> Am 2026-03-11 22:07, schrieb Jakub Zelenka:
> >> > I also think that there is not really much use case for user space t=
o
> >> > implement their own handles so such interface would be used only
> >> > internally
> >> > anyway.
> >>
> >> This applies equally to interfaces and abstract methods. The abstract
> >> base class however will make it much weirder when a specific (future)
> >> handle might need to implement additional interfaces or abstract
> >> classes.
> >>
> >> > In addition interface would effectively expose the internal stream f=
d
> >> > which
> >> > is currently hidden and makes harder messing up with stream fd which
> >> > might
> >> > cause various issues.
> >>
> >> I don't understand that point. For both an interface and an abstract
> >> method, the method would exist on the child class and thus can be
> >> called
> >> by a developer.
> >>
> >>
> > Well if it is abstract, then the method can be protected and because
> > the
> > classes are final, user spaces cannot call it. But for interface I
> > would
>
> Protected methods of internal classes should still be accessible to
> Reflection.
>
>
Good point.


> > need to make it public which means that StreamHandle would need to
> > expose
> > callabable (public) method. I know that I could just return 0 and use
> > different handling internally but I think this would be surprising and
> > created obvious inconsistency. I mean it's fine if the calls happen
> > internally but if the exposed methods are just dummy and return
> > nonsense
> > for user space, then I don't think it would be a good design.
>
> It's equally weird that there is a protected method that is effectively
> internally called by an unrelated class (Context) that is not supposed
> to know about it. Perhaps the correct solution would then be removing
> the `getFileDescriptor()` method from the public API entirely and change
> `Handle` to be an empty =E2=80=9Cmarker interface=E2=80=9D that cannot be=
 implemented in
> userland (similarly to Throwable) to leave all options open for the
> future?
>
>
This (marker interface just for internal classes) is actually a really good
idea. Will change it.

Thanks

Jakub

--000000000000b4b611064e51e4fe
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quote gmail_quote_co=
ntainer"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Mar 31, 2026 at 11:2=
3=E2=80=AFAM Tim D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim=
@bastelstu.be</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">Hi<br>
<br>
Sorry for the late feedback, it&#39;s hard juggling all the different RFCs =
<br>
that are in progress to provide meaningful feedback.<br>
<br>
Am 2026-03-11 22:07, schrieb Jakub Zelenka:<br>
&gt;&gt; &gt; I also think that there is not really much use case for user =
space to<br>
&gt;&gt; &gt; implement their own handles so such interface would be used o=
nly<br>
&gt;&gt; &gt; internally<br>
&gt;&gt; &gt; anyway.<br>
&gt;&gt; <br>
&gt;&gt; This applies equally to interfaces and abstract methods. The abstr=
act<br>
&gt;&gt; base class however will make it much weirder when a specific (futu=
re)<br>
&gt;&gt; handle might need to implement additional interfaces or abstract<b=
r>
&gt;&gt; classes.<br>
&gt;&gt; <br>
&gt;&gt; &gt; In addition interface would effectively expose the internal s=
tream fd<br>
&gt;&gt; &gt; which<br>
&gt;&gt; &gt; is currently hidden and makes harder messing up with stream f=
d which<br>
&gt;&gt; &gt; might<br>
&gt;&gt; &gt; cause various issues.<br>
&gt;&gt; <br>
&gt;&gt; I don&#39;t understand that point. For both an interface and an ab=
stract<br>
&gt;&gt; method, the method would exist on the child class and thus can be =
<br>
&gt;&gt; called<br>
&gt;&gt; by a developer.<br>
&gt;&gt; <br>
&gt;&gt; <br>
&gt; Well if it is abstract, then the method can be protected and because <=
br>
&gt; the<br>
&gt; classes are final, user spaces cannot call it. But for interface I <br=
>
&gt; would<br>
<br>
Protected methods of internal classes should still be accessible to <br>
Reflection.<br>
<br></blockquote><div><br></div><div>Good point.</div><div>=C2=A0</div><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left=
:1px solid rgb(204,204,204);padding-left:1ex">
&gt; need to make it public which means that StreamHandle would need to <br=
>
&gt; expose<br>
&gt; callabable (public) method. I know that I could just return 0 and use<=
br>
&gt; different handling internally but I think this would be surprising and=
<br>
&gt; created obvious inconsistency. I mean it&#39;s fine if the calls happe=
n<br>
&gt; internally but if the exposed methods are just dummy and return <br>
&gt; nonsense<br>
&gt; for user space, then I don&#39;t think it would be a good design.<br>
<br>
It&#39;s equally weird that there is a protected method that is effectively=
 <br>
internally called by an unrelated class (Context) that is not supposed <br>
to know about it. Perhaps the correct solution would then be removing <br>
the `getFileDescriptor()` method from the public API entirely and change <b=
r>
`Handle` to be an empty =E2=80=9Cmarker interface=E2=80=9D that cannot be i=
mplemented in <br>
userland (similarly to Throwable) to leave all options open for the <br>
future?<br>
<br></blockquote><div><br></div><div>This (marker interface just for intern=
al classes) is actually a really good idea. Will change it.</div><div><br><=
/div><div>Thanks</div><div><br></div><div>Jakub</div></div></div>

--000000000000b4b611064e51e4fe--