Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130433
Precedence: list
MIME-Version: 1.0
References: <3f4f6959.eaf.19cf0276cd8.Coremail.lamentxu@163.com> <4bf704c.b746.19d20d429ac.Coremail.lamentxu@163.com>
In-Reply-To: <4bf704c.b746.19d20d429ac.Coremail.lamentxu@163.com>
Date: Tue, 24 Mar 2026 12:29:11 -0600
Message-ID: <CAAKU0umogV26u-Y9jc76XfU4cF4CN22Hs72bCYs1YQtYpac1qA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Remove \0 from default trim() character mask
To: LamentXU <lamentxu@163.com>
Cc: "1372449351@qq.com" <1372449351@qq.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: levi.morrison@datadoghq.com (Levi Morrison)

On Tue, Mar 24, 2026 at 11:14=E2=80=AFAM LamentXU <lamentxu@163.com> wrote:
>
> Hi all,
>
> I believe the RFC =E2=80=9CDon't trim NUL bytes by default=E2=80=9D is re=
ady to move to the voting phase. I intend to open the voting period soon (t=
ypically 7 days).
>
> RFC page: https://wiki.php.net/rfc/dont_trim_nul
>
> This RFC proposes to remove \0 (NUL byte) from the default character mask=
 of trim(), ltrim(), and rtrim(), to align with common expectations and avo=
id unintended trimming of legitimate NUL-containing strings. Please tell me=
 if there are any final comments or concerns. Thanks.
>
> Best regards,
> Weilin Du
>
> p.s. Not that sure if this email is going be be sent in the correct threa=
d, so I would post the thread link here if it doesn't https://externals.io/=
message/130318

I agree that \0 is a control byte and not whitespace, so it probably
shouldn't be included in any of the trim functions. However, at this
stage in PHP's lifecycle I am not sure if we should fix it.

There hasn't been much discussion, so dear internals: are simply busy,
un-opinionated, or what?