Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130213
Precedence: list
MIME-Version: 1.0
References: <CAEKnhAG1KW-D+THEpm+C-e5caCNRPVhx61zLkZGjn_WaLcjRTA@mail.gmail.com>
 <2d741c45-9c92-4404-a0d5-02bf26a557b1@bastelstu.be> <CAEKnhAFndXvd=YKFx5aN8yH=kw2NJ5NW_+mOX8OxUYfOYOpapw@mail.gmail.com>
 <cfbcf25d43c6235688c25792a9857c4b@bastelstu.be>
In-Reply-To: <cfbcf25d43c6235688c25792a9857c4b@bastelstu.be>
Date: Sun, 1 Mar 2026 20:48:45 +0100
Message-ID: <CAEKnhAHy3Zr5wnqoX4Z7zP=eQ8CfK9G7i6tq_9SV9z4NC+fJiw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] TLS Session Resumption Support for Streams
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c3dde7064bfbc2e5"
From: bukka@php.net (Jakub Zelenka)

--000000000000c3dde7064bfbc2e5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Thanks for the feedback.

On Sun, Mar 1, 2026 at 2:05=E2=80=AFPM Tim D=C3=BCsterhus <tim@bastelstu.be=
> wrote:

>
> For OpenSSLSession::import() and ::export() however, the RFC mentions
> \Exception being thrown on failure. According to the =E2=80=9CThrowable=
=E2=80=9D policy
> (
> https://github.com/php/policies/blob/main/coding-standards-and-naming.rst=
#throwables),
>
> this should be an extension-specific Exception. Since the hierarchy to
> use is clearly specified in the policy, adding:
>
>      class \Openssl\OpensslException extends \Exception { }
>      class \Openssl\OpensslError extends \Error { }
>
> can be done without an RFC.
>
> Then the ::import() function can use `class
> \Openssl\InvalidResumptionDataException extends
> \Openssl\OpensslExceptoin { }` or similar and for ::export() just using
> `OpensslException` directly is probably okay.
>
> For the OpenSSLSession class, I leave it up to you whether it makes
> sense to also move it into the `Openssl` namespace or not (as
> Openssl\Session). The policy leaves some freedom here, since it's not
> directly related to any of the existing classes:
>
>
> https://github.com/php/policies/blob/main/coding-standards-and-naming.rst=
#existing-non-namespaced-symbols-and-consistency
>
>
The policy recommends consistency with existing symbols and there are
already OpenSSLCertificate, OpenSSLCertificateSigningRequest and
OpenSSLAsymmetricKey. So I think we should stick with no namespace here and
calls it OpenSSLSession and OpenSSLException. I will introduce that
exception as I agree it makes more sense.

Kind regards,

Jakub

--000000000000c3dde7064bfbc2e5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><div><br></div><div>Thanks for the feedback.=
</div><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr"=
 class=3D"gmail_attr">On Sun, Mar 1, 2026 at 2:05=E2=80=AFPM Tim D=C3=BCste=
rhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be</a>&gt; wrote=
:</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;=
border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
For OpenSSLSession::import() and ::export() however, the RFC mentions <br>
\Exception being thrown on failure. According to the =E2=80=9CThrowable=E2=
=80=9D policy <br>
(<a href=3D"https://github.com/php/policies/blob/main/coding-standards-and-=
naming.rst#throwables" rel=3D"noreferrer" target=3D"_blank">https://github.=
com/php/policies/blob/main/coding-standards-and-naming.rst#throwables</a>),=
 <br>
this should be an extension-specific Exception. Since the hierarchy to <br>
use is clearly specified in the policy, adding:<br>
<br>
=C2=A0 =C2=A0 =C2=A0class \Openssl\OpensslException extends \Exception { }<=
br>
=C2=A0 =C2=A0 =C2=A0class \Openssl\OpensslError extends \Error { }<br>
<br>
can be done without an RFC.<br>
<br>
Then the ::import() function can use `class <br>
\Openssl\InvalidResumptionDataException extends <br>
\Openssl\OpensslExceptoin { }` or similar and for ::export() just using <br=
>
`OpensslException` directly is probably okay.<br>
<br>
For the OpenSSLSession class, I leave it up to you whether it makes <br>
sense to also move it into the `Openssl` namespace or not (as <br>
Openssl\Session). The policy leaves some freedom here, since it&#39;s not <=
br>
directly related to any of the existing classes:<br>
<br>
<a href=3D"https://github.com/php/policies/blob/main/coding-standards-and-n=
aming.rst#existing-non-namespaced-symbols-and-consistency" rel=3D"noreferre=
r" target=3D"_blank">https://github.com/php/policies/blob/main/coding-stand=
ards-and-naming.rst#existing-non-namespaced-symbols-and-consistency</a><br>=
<br></blockquote><div><br></div><div>The policy recommends consistency with=
 existing symbols and there are already=C2=A0OpenSSLCertificate,=C2=A0OpenS=
SLCertificateSigningRequest and OpenSSLAsymmetricKey. So I think we should =
stick with no namespace here and calls it=C2=A0OpenSSLSession and=C2=A0Open=
SSLException. I will introduce that exception as I agree it makes more sens=
e.</div><div><br></div><div>Kind regards,</div><div><br></div><div>Jakub</d=
iv></div></div>

--000000000000c3dde7064bfbc2e5--